Stabilize to_bytes and from_bytes for integers. #51835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit c8f9b84 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 27, 2018
Stabilize to_bytes and from_bytes for integers. Fixes #49792
kennytm
added
the
relnotes
|
☀️ Test successful - status-appveyor, status-travis |
ALCC01
added a commit
to ALCC01/sigil
that referenced
this pull request
Jul 17, 2018
* Remove reliance on unstable feature int_to_from_bytes * Add a fallback method until feature becomes stable in Rust 1.29 * See rust-lang/rust#51835 * Remove reliance on experimental feature attr_literals * Only used for `structopt`, but it provides `raw()` * See rust-lang/rust#34981 * Make tests run again
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 30, 2018
Revert "Stabilize to_bytes and from_bytes for integers." This reverts commit c8f9b84 / PR rust-lang#51835, and reopens the tracking issue rust-lang#49792. These methods were stabilized in Rust 1.29, which is still in Nightly as of this writing. So my understanding is that it is still time to change our minds. Given the ongoing discussion in rust-lang#51919 about possibly renaming these APIs and since 1.29 goes to beta soon, I’d like to revert this stabilization for now until a decision is made in that PR. It’s possible that a decision will be made in time for 1.29, but there is no urgency. At most I expect this functionality to make it into 1.30.
bors
added a commit
that referenced
this pull request
Jul 31, 2018
Revert "Stabilize to_bytes and from_bytes for integers." This reverts commit c8f9b84 / PR #51835, and reopens the tracking issue #49792. These methods were stabilized in Rust 1.29, which is still in Nightly as of this writing. So my understanding is that it is still time to change our minds. Given the ongoing discussion in #51919 about possibly renaming these APIs and since 1.29 goes to beta soon, I’d like to revert this stabilization for now until a decision is made in that PR. It’s possible that a decision will be made in time for 1.29, but there is no urgency. At most I expect this functionality to make it into 1.30.
kennytm
removed
the
relnotes
|
This PR has been reverted by #52850 and no longer part of 1.29. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49792