Document rounding down in std::time::Durations's subsec_millis etc. #52372
Conversation
Now also the documentations of `subsec_millis`, `subsec_micros`, `as_millis` and `as_micros` make clear that the fractional nanosecond component is rounded down to whole units.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 9a86e3d has been approved by |
bors
added
S-waiting-on-bors
…r=joshtriplett Document rounding down in std::time::Durations's subsec_millis etc. Now also the documentations of `subsec_millis`, `subsec_micros`, `as_millis` and `as_micros` make clear that the fractional nanosecond component is rounded down to whole units. Fixed #52263
|
☀️ Test successful - status-appveyor, status-travis |
Now also the documentations of
subsec_millis,subsec_micros,as_millisandas_microsmake clear that the fractional nanosecond component is rounded down to whole units.Fixed #52263