Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static infer feature gate #52761

Merged
merged 5 commits into from
Jul 28, 2018
Merged

static infer feature gate #52761

merged 5 commits into from
Jul 28, 2018

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Jul 27, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2018
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@nikomatsakis
Copy link
Contributor

@bors r+ p=1 -- edition preview 2 blocker

@bors
Copy link
Contributor

bors commented Jul 28, 2018

📌 Commit 130e3ab has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2018
@bors
Copy link
Contributor

bors commented Jul 28, 2018

⌛ Testing commit 130e3ab with merge 38da099e41ea5b5e904a6bf97332f6d63d4507af...

@bors
Copy link
Contributor

bors commented Jul 28, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 28, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:14:13] * inclusive_range_methods          lib      stable       1.27.0  
[00:14:13] * inclusive_range_syntax           lang     stable       1.26.0  
[00:14:13] * indirect_hasher_impl             lib      stable       1.22.0  
[00:14:13] * infer_outlives_requirements      lang     unstable     1.26.0  
[00:14:13] * infer_static_outlives_requirements lang     unstable     1.26.0  
[00:14:13] * int_error_internals              lib      unstable     None    
[00:14:13] * int_to_from_bytes                lib      stable       1.29.0  
[00:14:13] * integer_atomics                  lib      unstable     None    
[00:14:13] * into_boxed_c_str                 lib      stable       1.20.0  
---
[01:47:52] warning: spurious network error (2 tries remaining): curl error: Couldn't resolve host 'github.com'
[01:47:52] ; class=Net (12)
[01:48:48] warning: spurious network error (1 tries remaining): curl error: Couldn't resolve host 'github.com'
[01:48:48] ; class=Net (12)
[01:49:44] error: failed to load source for a dependency on `rand`
[01:49:44] Caused by:
[01:49:44]   Unable to update registry `https://github.com/rust-lang/crates.io-index`
[01:49:44] 
[01:49:44] Caused by:
[01:49:44] Caused by:
[01:49:44]   failed to fetch `https://github.com/rust-lang/crates.io-index`
[01:49:44] 
[01:49:44] Caused by:
[01:49:44]   curl error: Couldn't resolve host 'github.com'
[01:49:44] ; class=Net (12)
[01:49:44] 
[01:49:44] 
[01:49:44] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "generate-lockfile" "--manifest-path" "/checkout/obj/build/tmp/distcheck-src/rust-src/lib/rustlib/src/rust/src/libstd/Cargo.toml"
[01:49:44] 
[01:49:44] 
[01:49:44] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[01:49:44] Build completed unsuccessfully in 1:46:57

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Jul 28, 2018

@bors retry travis-ci/travis-ci#9696

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2018
@bors
Copy link
Contributor

bors commented Jul 28, 2018

⌛ Testing commit 130e3ab with merge 5b465e3...

bors added a commit that referenced this pull request Jul 28, 2018
@bors
Auto merge of #52761 - toidiu:ak-static-infer-fg, r=nikomatsakis
5b465e3 
static infer feature gate

#44493

r? @nikomatsakis
@bors
Copy link
Contributor

bors commented Jul 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 5b465e3 to master...

@bors bors merged commit 130e3ab into rust-lang:master Jul 28, 2018
joshtriplett
joshtriplett reviewed Jul 28, 2018
View reviewed changes
src/libsyntax/feature_gate.rs
@@ -396,6 +396,9 @@ declare_features! (
// Infer outlives requirements; RFC 2093
(active, infer_outlives_requirements, "1.26.0", Some(44493), None),

// Infer outlives requirements; RFC 2093
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use a different comment than the previous entry, to distinguish it. Infer 'static outlives requirements, perhaps?

@joshtriplett joshtriplett mentioned this pull request Jul 28, 2018
Closed
3 tasks
@toidiu toidiu deleted the ak-static-infer-fg branch July 30, 2018 01:14
@toidiu toidiu mentioned this pull request Jul 30, 2018
Merged
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 30, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#52842 - toidiu:ak-commentUpdate, r=estebank
ea49a74 
update comment

r? @joshtriplett

Addressing comment: rust-lang#52761 (review)
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 30, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#52842 - toidiu:ak-commentUpdate, r=estebank
406c7f5 
update comment

r? @joshtriplett

Addressing comment: rust-lang#52761 (review)
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 31, 2018
@GuillaumeGomez
Rollup merge of rust-lang#52842 - toidiu:ak-commentUpdate, r=estebank
043b1a1 
update comment

r? @joshtriplett

Addressing comment: rust-lang#52761 (review)
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 1, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#52842 - toidiu:ak-commentUpdate, r=estebank
3f6186f 
update comment

r? @joshtriplett

Addressing comment: rust-lang#52761 (review)
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 1, 2018
@pietroalbini
Rollup merge of rust-lang#52842 - toidiu:ak-commentUpdate, r=estebank
a819a6c 
update comment

r? @joshtriplett

Addressing comment: rust-lang#52761 (review)
@nikomatsakis nikomatsakis mentioned this pull request Sep 13, 2018
Closed
@pnkfelix pnkfelix mentioned this pull request Oct 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtriplett joshtriplett joshtriplett left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@toidiu @rust-highfive @nikomatsakis @bors @kennytm @joshtriplett