region error messages involving impls are confusing #53124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
1 similar comment
|
@bors r+ |
|
📌 Commit 12037ff has been approved by |
bors
added
S-waiting-on-bors
|
@bors delegate=davidtwco |
|
✌️ @davidtwco can now approve this pull request |
cramertj
added a commit
to cramertj/rust
that referenced
this pull request
Aug 8, 2018
region error messages involving impls are confusing Part of rust-lang#52742. r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Aug 9, 2018
region error messages involving impls are confusing Part of #52742. r? @nikomatsakis
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@bors r- failures:
---- [ui] ui\nll\issue-52742.rs stdout ----
diff of stderr:
- error: unsatisfied lifetime constraints
- --> $DIR/issue-52742.rs:25:9
+ error[E0106]: missing lifetime specifiers
+ --> $DIR/issue-52742.rs:23:10
3 |
- LL | fn take_bar(&mut self, b: Bar<'_>) {
- | --------- -- let's call this `'1`
- | |
- | has type `&mut Foo<'_, '2>`
- LL | self.y = b.z
- | ^^^^^^^^^^^^ requires that `'1` must outlive `'2`
+ LL | impl Foo<'_, '_> {
+ | ^^ expected 2 lifetime parameters
10
11 error: aborting due to previous error
12
+ For more information about this error, try `rustc --explain E0106`.
13 |
bors
added
S-waiting-on-author
nikomatsakis
reviewed
Aug 9, 2018
| // except according to those terms. | ||
|
|
||
| #![feature(nll)] | ||
| #![feature(in_band_lifetimes)] |
There was a problem hiding this comment.
the problem here is that we now need another feature gate here
#![feature(impl_header_lifetime_elision)]
|
@bors r+ |
|
📌 Commit 31657c9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 10, 2018
region error messages involving impls are confusing Part of #52742. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #52742.
r? @nikomatsakis