Start adding an aarch64-pc-windows-msvc target
#53173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @froydnj |
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Given the test file in LLVM repo, shouldn't this call |
|
Perhaps! I'm thinking though it's probably best to stick to the convention we already have for our MSVC targets |
|
Ping from triage @sfackler. This PR requires your review. |
|
cc #52659 |
sfackler
reviewed
Aug 15, 2018
| /// | ||
| /// This allows you to conveniently provide a long list `#[cfg]`'d blocks of code | ||
| /// without having to rewrite each clause multiple times. | ||
| macro_rules! cfg_if { |
There was a problem hiding this comment.
Don't we already pull the cfg_if crate in?
There was a problem hiding this comment.
Nah unfortunately for libstd it's trickier, so it's just inlined here in our facade crates
sfackler
reviewed
Aug 15, 2018
|
|
||
| // FIXME: this shouldn't be panic=abort, it should be panic=unwind | ||
| base.panic_strategy = PanicStrategy::Abort; | ||
| base.linker = Some("rust-lld".to_owned()); |
There was a problem hiding this comment.
Is the use of LLD a fixme or the right long term approach?
There was a problem hiding this comment.
Sort of! Using LLD would be nice in that it's likely faster than link.exe and we can fix bugs more easily (and probably use more features), but for the time being it's a FIXME in that the native linker aborted earlier than I expected.
I suspect that long term we'll be using link.exe like the other MSVC targets unless we have strong reasons to not do so. (like now with it being seemingly buggy)
|
@bors r+ |
|
📌 Commit 5863dee3d340145d34f1515f61e26e9f1a289ead has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 5863dee3d340145d34f1515f61e26e9f1a289ead with merge ff6daf7b6024ad7716f56115af6116620b56f0c2... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This commit adds the necessary definitions for target specs and such as well as
the necessary support in libstd to compile basic `aarch64-pc-windows-msvc`
binaries. The target is not currently built on CI, but it can be built locally
with:
./configure --target=aarch64-pc-windows-msvc --set rust.lld
./x.py build src/libstd --target aarch64-pc-windows-msvc
Currently this fails to build `libtest` due to a linker bug (seemingly in LLD?)
which hasn't been investigate yet. Otherwise though with libstd you can build a
hello world program (linked with LLD). I've not tried to execute it yet, but it
at least links!
Full support for this target is still a long road ahead, but this is hopefully a
good stepping stone to get started.
Points of note about this target are:
* Currently defaults to `panic=abort` as support is still landing in LLVM for
SEH on AArch64.
* Currently defaults to LLD as a linker as I was able to get farther with it
than I was with `link.exe`
alexcrichton
force-pushed
the
win-arm64
branch
from
5863dee to
fccc04d
Compare
|
@bors: r=sfackler |
|
📌 Commit fccc04d has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit fccc04d with merge bd69a2b419784a95663514816db52c1048607a71... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 16, 2018
Start adding an `aarch64-pc-windows-msvc` target
This commit adds the necessary definitions for target specs and such as well as
the necessary support in libstd to compile basic `aarch64-pc-windows-msvc`
binaries. The target is not currently built on CI, but it can be built locally
with:
./configure --target=aarch64-pc-windows-msvc --set rust.lld
./x.py build src/libstd --target aarch64-pc-windows-msvc
Currently this fails to build `libtest` due to a linker bug (seemingly in LLD?)
which hasn't been investigate yet. Otherwise though with libstd you can build a
hello world program (linked with LLD). I've not tried to execute it yet, but it
at least links!
Full support for this target is still a long road ahead, but this is hopefully a
good stepping stone to get started.
Points of note about this target are:
* Currently defaults to `panic=abort` as support is still landing in LLVM for
SEH on AArch64.
* Currently defaults to LLD as a linker as I was able to get farther with it
than I was with `link.exe`
|
☀️ Test successful - status-appveyor, status-travis |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 22, 2018
…dorn This is the LLVM target name that's getting used in rust-lang/rust#53173.
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Aug 22, 2018
…dorn This is the LLVM target name that's getting used in rust-lang/rust#53173.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…dorn This is the LLVM target name that's getting used in rust-lang/rust#53173. UltraBlame original commit: aebd6f51d2e5125b1a0be102a6f1c93fa377425f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…dorn This is the LLVM target name that's getting used in rust-lang/rust#53173. UltraBlame original commit: aebd6f51d2e5125b1a0be102a6f1c93fa377425f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…dorn This is the LLVM target name that's getting used in rust-lang/rust#53173. UltraBlame original commit: aebd6f51d2e5125b1a0be102a6f1c93fa377425f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the necessary definitions for target specs and such as well as
the necessary support in libstd to compile basic
aarch64-pc-windows-msvcbinaries. The target is not currently built on CI, but it can be built locally
with:
Currently this fails to build
libtestdue to a linker bug (seemingly in LLD?)which hasn't been investigate yet. Otherwise though with libstd you can build a
hello world program (linked with LLD). I've not tried to execute it yet, but it
at least links!
Full support for this target is still a long road ahead, but this is hopefully a
good stepping stone to get started.
Points of note about this target are:
panic=abortas support is still landing in LLVM forSEH on AArch64.
than I was with
link.exe