Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLL - Prevent where clauses from extending the lifetime of bindings #53212

Merged
merged 2 commits into from
Aug 15, 2018
Merged

NLL - Prevent where clauses from extending the lifetime of bindings #53212

merged 2 commits into from
Aug 15, 2018

Conversation

sunjay
Copy link
Member

@sunjay sunjay commented Aug 9, 2018 •
edited
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2018
@rust-highfive

This comment has been minimized.

Sign in to view
@sunjay
Copy link
Member Author

sunjay commented Aug 9, 2018

@nikomatsakis I made it so that BuiltInCandidate { has_nested: false } is preferred in all cases. This makes it so that the single test case from the bug compiles, but I do not know the implications of this change on everything else just yet. The test suite is running and we'll see if anything breaks.

I also don't believe that the added test case covers all of the changes that I made. Since I made it so that BuiltInCandidate { has_nested: false } is preferred in all cases, we should consider adding a few more tests that will cause some of those cases to occur. I do not know what those cases would look like yet, so some guidance would be wonderful. If you don't think that is necessary, and if the tests pass, this can probably be merged as is.

@sunjay sunjay changed the title [WIP] NLL - Prevent where clauses from extending the lifetime of bindings NLL - Prevent where clauses from extending the lifetime of bindings Aug 9, 2018
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 10, 2018

📌 Commit 6447651 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2018
@bors
Copy link
Contributor

bors commented Aug 15, 2018

⌛ Testing commit 6447651 with merge 81cfaad...

bors added a commit that referenced this pull request Aug 15, 2018
@bors
Auto merge of #53212 - sunjay:nll-raw-cast, r=nikomatsakis
81cfaad 
NLL - Prevent where clauses from extending the lifetime of bindings

Fixes #53123

r? @nikomatsakis
@bors
Copy link
Contributor

bors commented Aug 15, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 81cfaad to master...

@bors bors merged commit 6447651 into rust-lang:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunjay @rust-highfive @nikomatsakis @bors