Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a implementation of From for converting &'a Option<T> into Option<&'a T> #53218

Merged
merged 3 commits into from
Sep 14, 2018
Merged

Add a implementation of From for converting &'a Option<T> into Option<&'a T> #53218

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef519c1
Add a implementation of `From` for converting `&'a Option<T>` into
weiznich Aug 9, 2018
0cde1cb
Add stability attribute
weiznich Aug 9, 2018
a7a0225
Also add a `From` implementation for `&mut Option<T>` -> `Option<&mut…
weiznich Aug 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/libcore/option.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,6 +1064,12 @@ impl<T> From<T> for Option<T> {
}
}

impl<'a, T> From<&'a Option<T>> for Option<&'a T> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if any annotations regarding the stabilization are needed

Yes this needs to be #[stable(feature = "option_ref_from_ref_option", since = "1.30.0")]. (The feature name can be anything unique). This is going to be insta-stable.

fn from(o: &'a Option<T>) -> Option<&'a T> {
o.as_ref()
}
}

/////////////////////////////////////////////////////////////////////////////
// The Option Iterators
/////////////////////////////////////////////////////////////////////////////
Expand Down