rustc_resolve: overhaul #![feature(uniform_paths)] error reporting.
#53427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors p=10 (somewhat blocking Edition Preview 2 testing) |
This was referenced Aug 16, 2018
This comment has been minimized.
This comment has been minimized.
eddyb
force-pushed
the
uniform-paths-diagnostics
branch
from
c81b481
to
a5bb0c6
Compare
This comment has been minimized.
This comment has been minimized.
eddyb
force-pushed
the
uniform-paths-diagnostics
branch
from
a5bb0c6
to
bcf864d
Compare
|
📌 Commit bcf864db8993218f9e8a2affe0e83c5a9810d402 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit bcf864db8993218f9e8a2affe0e83c5a9810d402 with merge 8d83a20b14dec23b2c82c9e2fa655ead377e8d04... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit bcf864db8993218f9e8a2affe0e83c5a9810d402 with merge 60de86d7c8dece92a7c289a0924574b2cdef4c3e... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
eddyb
force-pushed
the
uniform-paths-diagnostics
branch
from
bcf864d
to
7a87e30
Compare
|
@bors r=varkor (sadly I don't think this will make the nightly, oops) |
|
📌 Commit 7a87e30 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 17, 2018
rustc_resolve: overhaul `#![feature(uniform_paths)]` error reporting. Fixes #53408 by only considering external crates to conflict within their (type/module) namespace, *not* with the value or macro namespaces, and also by adding a special-cased error for redundant `use crate_name;` imports (without actually allowing them). Also, all canaries for a given import are grouped into one diagnostic per namespace, in order to make block-scoped ambiguities clearer. See changed/added tests for more details. r? @petrochenkov cc @aturon @joshtriplett
|
☀️ Test successful - status-appveyor, status-travis |
| | refers to external crate `::std` | ||
| | defines `self::std`, shadowing itself | ||
| | | ||
| = help: remove or write `::std` explicitly instead |
There was a problem hiding this comment.
Wouldn't use ::somecrate; be redundant as well, because extern_prelude makes somecrate already available?
There was a problem hiding this comment.
It's redundant for direct uses of the imported name but maybe you actually want use ::std as _; or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53408 by only considering external crates to conflict within their (type/module) namespace, not with the value or macro namespaces, and also by adding a special-cased error for redundant
use crate_name;imports (without actually allowing them).Also, all canaries for a given import are grouped into one diagnostic per namespace, in order to make block-scoped ambiguities clearer.
See changed/added tests for more details.
r? @petrochenkov cc @aturon @joshtriplett