Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for impl From in char_convert #53518

Merged
merged 2 commits into from
Sep 26, 2018
Merged

Add doc for impl From in char_convert #53518

merged 2 commits into from
Sep 26, 2018

Conversation

phungleson
Copy link
Contributor

As part of issue #51430 (cc @skade).

The impl is very simple, let me know if we need to go into any details.

@rust-highfive
Copy link
Collaborator

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:55:55] ....................................................................................................
[00:55:59] ....................................................................................................
[00:56:01] .......i............................................................................................
[00:56:05] ....................................................................................................
[00:56:07] ........................................................iiiiiiiii...................................
[00:56:14] ....................................................................................................
[00:56:18] ....................................................................................................
[00:56:20] ....................................i...............................................................
[00:56:23] ......................................................................................i.i..ii.......
---
[01:27:26] travis_fold:end:stage0-linkchecker

[01:27:26] travis_time:end:stage0-linkchecker:start=1534736774109096078,finish=1534736776688149991,duration=2579053913

[01:27:31] std/primitive.u32.html:1147: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.char.html
[01:27:31] std/primitive.u32.html:1147: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u32.html
[01:27:34] std/primitive.char.html:883: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.u8.html
[01:27:34] std/primitive.char.html:883: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/primitive.char.html
[01:27:40] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:27:40] 
[01:27:40] 
[01:27:40] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:27:40] expected success, got: exit code: 101
[01:27:40] expected success, got: exit code: 101
[01:27:40] 
[01:27:40] 
[01:27:40] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:27:40] Build completed unsuccessfully in 0:36:11
[01:27:40] Makefile:58: recipe for target 'check' failed
[01:27:40] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1f1bae08
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:041f67b2:start=1534736793974817838,finish=1534736794067225904,duration=92408066
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:00f9323f
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:03b71e6b
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@dtolnay
Copy link
Member

dtolnay commented Aug 20, 2018

@bors delegate=skade

@bors
Copy link
Contributor

bors commented Aug 20, 2018

✌️ @skade can now approve this pull request

@pietroalbini
Copy link
Member

Ping from triage @skade! This PR needs your review.

@TimNN
Copy link
Contributor

TimNN commented Sep 4, 2018

Ping from triage, @skade / @rust-lang/docs: This PR requires your review.

@GuillaumeGomez
Copy link
Member

Please add examples (yes, even for this docs adds!).

@phungleson
Copy link
Contributor Author

Hey, I am currently traveling, will look at this again in around 3 weeks.

@TimNN TimNN added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2018
frewsxcv
frewsxcv approved these changes Sep 25, 2018
View reviewed changes
Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frewsxcv
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 25, 2018

📌 Commit 992e220 has been approved by frewsxcv

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 25, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Sep 25, 2018
@pietroalbini
Rollup merge of rust-lang#53518 - phungleson:fix-impl-from-for-conver…
707c979 
…t, r=frewsxcv

Add doc for impl From in char_convert

As part of issue rust-lang#51430 (cc @skade).

The impl is very simple, let me know if we need to go into any details.
@pietroalbini pietroalbini mentioned this pull request Sep 25, 2018
Merged
bors added a commit that referenced this pull request Sep 25, 2018
@bors
Auto merge of #54575 - pietroalbini:rollup, r=pietroalbini
92aff72 
Rollup of 12 pull requests

Successful merges:

 - #53518 (Add doc for impl From in char_convert)
 - #54058 (Introduce the partition_dedup/by/by_key methods for slices)
 - #54281 (Search box)
 - #54368 (Reduce code block sides padding)
 - #54498 (The project moved under the Mozilla umbrella)
 - #54518 (resolve: Do not block derive helper resolutions on single import resolutions)
 - #54522 (Fixed three small typos.)
 - #54529 (aarch64-pc-windows-msvc: Don't link libpanic_unwind to libtest.)
 - #54537 (Rename slice::exact_chunks() to slice::chunks_exact())
 - #54539 (Fix js error)
 - #54557 (incr.comp.: Don't automatically enable -Zshare-generics for incr. comp. builds.)
 - #54558 (Improvements to finding LLVM's FileCheck)

Failed merges:

r? @ghost
@bors bors merged commit 992e220 into rust-lang:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees

@Kimundi Kimundi

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@phungleson @rust-highfive @dtolnay @bors @pietroalbini @TimNN @GuillaumeGomez @frewsxcv @Kimundi