-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge IdxSet
and IdxSetBuf
#53520
Merge IdxSet
and IdxSetBuf
#53520
Conversation
This makes it more like `AllSets::{gen,kill}_set`, removes the need for a bunch of bitset range computations, and removes the need for `Bits`. It's marginally less efficient, because we have to allocate one bitset per basic block instead of one large shared bitset, but the difference is negligible in practice.
The `Buf` vs. non-`Buf` distinction is no longer necessary, and the nastiest code in this file can be removed. To minimize this patch, `IdxSet` is made a typedef of `IdxSetBuf`. The next patch will remove this typedef.
Now that the `Buf` vs. non-`Buf` distinction has been removed, it makes sense to drop the `Buf` suffix and use the shorter names everywhere.
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
@bors try |
⌛ Trying commit e7e9f2e with merge 3d5c7019ca98038841575ca04bca95093b3abe4f... |
☀️ Test successful - status-travis |
@rust-timer build 3d5c7019ca98038841575ca04bca95093b3abe4f |
Success: Queued 3d5c7019ca98038841575ca04bca95093b3abe4f with parent d2048b6, comparison URL. |
The comparison URL shows that there is no regression of note. ( |
@bors r+ |
📌 Commit e7e9f2e has been approved by |
… r=nikomatsakis Merge `IdxSet` and `IdxSetBuf` Because it simplifies things. @r? nikomatsakis
…akis Merge `IdxSet` and `IdxSetBuf` Because it simplifies things. @r? nikomatsakis
☀️ Test successful - status-appveyor, status-travis |
Because it simplifies things.
@r? nikomatsakis