-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enum keyword #53726
Add enum keyword #53726
Conversation
src/libstd/keyword_docs.rs
Outdated
/// } | ||
/// ``` | ||
/// | ||
/// Very convenient to handle different kind of data. To get what value an enum instance is, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start of sentence "Very.." feels odd.
src/libstd/keyword_docs.rs
Outdated
/// } | ||
/// ``` | ||
/// | ||
/// Very convenient to handle different kind of data. To get what value an enum instance is, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use the word "variant" instead of "value"; and "see" instead of "get.
So: "To see which variant a value of an enum type is of, you can use pattern matching on the value:"
Ping from triage @QuietMisdreavus / @rust-lang/doc: This PR requires your review. Also ping @GuillaumeGomez: Some changes have already been requested to your PR. |
466d98f
to
0a23c42
Compare
Updated. |
Ping from triage @QuietMisdreavus / @rust-lang/docs: This PR requires your review. |
This PR now clashes with #53931, since she's since added docs for |
I would built upon the one in #53931 since it is more elaborate and gives background info. |
Then I'm closing this one. |
r? @QuietMisdreavus