Begin refactoring deriving code and implement #[deriving(TotalOrd)] #5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold off on reviewing this; there's one small issue I just uncovered. Will rebase shortly. |
|
Rebase complete. |
|
Closing this while I do some more work on it. |
ghost
closed this
ghost
reopened this
ghost
closed this
ghost
deleted the
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
…n, r=matthiaskrgr Move verbose_file_reads to restriction cc rust-lang#5368 Using `File::read` instead of `fs::read_to_end` does make sense in multiple cases, so this lint is rather restriction, than complexity changelog: Move [`verbose_file_reads`] to restriction
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit breaks the 1200-line
deriving.rsinto multiple submodules, one for each derivable trait. I haven't made any effort yet to clean that code up, however.The second commit introduces
#[deriving(TotalOrd)], which creates an implementation based on the successive comparison of all struct/enum fields in their declaration order. A future patch will allow this to be configured in the attribute.