Add rust-gdbgui script. #53774
Add rust-gdbgui script. #53774
Conversation
This script invokes the gdbgui graphical GDB front-end with the Rust pretty printers loaded. The script does not install gdbgui, that must be done manually.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
r? @tromey |
src/etc/rust-gdbgui
Outdated
| pretty printers loaded. | ||
|
|
||
| Simple usage : rust-gdbgui target\debug\myprog | ||
| With arguments: rust-gdbgui 'target\debug\myprog arg1 arg2...' |
There was a problem hiding this comment.
I think this should use forward slashes rather than backslashes.
I think this part is fine, because this seems to be how gdbgui itself works -- a bit ugly but not your problem. |
|
@bors r+ |
|
@tromey: 🔑 Insufficient privileges: Not in reviewers |
|
@bors r=tromey delegate=tromey rollup |
|
✌️ @tromey can now approve this pull request |
|
📌 Commit 47aa475 has been approved by |
bors
added
S-waiting-on-bors
Add rust-gdbgui script. This script invokes the [gdbgui](https://gdbgui.com/) graphical GDB front-end with the Rust pretty printers loaded. The script does not install gdbgui, that must be done manually. As an escapee from Visual Studio it is nice to have a point-and-click debugger. This script invokes `gdbgui` similarly to the way that `rust-gdb` invokes `gdb` - I copied that script as a starting point. Because it is a wrapper around a wrapper you don't have as much flexibility in passing arguments to GDB and I could not find a way to eliminate the single quotes you have to use when you want to pass arguments to your program (`gdbgui` supposedly supports an `--args` option which I think should allow this, but I couldn't get it to work, my shell-fu is weak). Still, I find this very usable for debugging programs, and it is a lot more approachable than gdb in the terminal.
Rollup of 9 pull requests Successful merges: - #53076 (set cfg(rustdoc) when rustdoc is running on a crate) - #53622 (cleanup: Add main functions to some UI tests) - #53769 (Also link Clippy repo in the CONTRIBUTING.md file) - #53774 (Add rust-gdbgui script.) - #53781 (bench: libcore: fix build failure of any.rs benchmark (use "dyn Any")) - #53782 (Make Arc cloning mechanics clearer in module docs) - #53790 (Add regression test for issue #52060) - #53801 (Prevent duplicated impl on foreign types) - #53850 (Nuke the `const_to_allocation` query)
|
@tromey Tom, I was expecting this script to show up in the |
|
Same here. Anything missing? |
Sorry - somehow I must have missed the notification for this. I think the new script must also be installed, see https://github.com/rust-lang/rust/blob/master/src/bootstrap/dist.rs#L603-L604 |
|
Thanks! I've opened #57708 |
…stall, r=Mark-Simulacrum Install missing 'rust-gdbui'' PR #53774 added `rust-gdbui` as wrapper to launch [gdbui](https://gdbgui.com/), similar to `rust-gdb`. Unfortunately I've never seen the script in my local installation (from rustup, using rust 1.31.1). @tromey on the PR [suggested it might be missing](#53774 (comment)) from the installation process. This PR simply adds a line for `rust-gdbui` too.
This script invokes the gdbgui graphical GDB front-end with the Rust pretty printers loaded. The script does not install gdbgui, that must be done manually.
As an escapee from Visual Studio it is nice to have a point-and-click debugger. This script invokes
gdbguisimilarly to the way thatrust-gdbinvokesgdb- I copied that script as a starting point.Because it is a wrapper around a wrapper you don't have as much flexibility in passing arguments to GDB and I could not find a way to eliminate the single quotes you have to use when you want to pass arguments to your program (
gdbguisupposedly supports an--argsoption which I think should allow this, but I couldn't get it to work, my shell-fu is weak). Still, I find this very usable for debugging programs, and it is a lot more approachable than gdb in the terminal.