-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc total order requirement of sort(_unstable)_by #53918
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1339,6 +1339,22 @@ impl<T> [T] { | |
/// This sort is unstable (i.e. may reorder equal elements), in-place (i.e. does not allocate), | ||
/// and `O(n log n)` worst-case. | ||
/// | ||
/// The comparator function must define a total ordering for the elements in the slice. If | ||
/// the ordering is not total, the order of the elements is unspecified. An order is a | ||
/// total order if it is (for all a, b and c): | ||
/// | ||
/// * total and antisymmetric: exactly one of a < b, a == b or a > b is true; and | ||
/// * transitive, a < b and b < c implies a < c. The same must hold for both == and >. | ||
/// | ||
/// For example, while [`f64`] doesn't implement [`Ord`] because `NaN != NaN`, we can use | ||
/// `partial_cmp` as our sort function when we know the slice doesn't contain a `NaN`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same. |
||
/// | ||
/// ``` | ||
/// let mut floats = [5f64, 4.0, 1.0, 3.0, 2.0]; | ||
/// floats.sort_by(|a, b| a.partial_cmp(b).unwrap()); | ||
/// assert_eq!(floats, [1.0, 2.0, 3.0, 4.0, 5.0]); | ||
/// ``` | ||
/// | ||
/// # Current implementation | ||
/// | ||
/// The current algorithm is based on [pattern-defeating quicksort][pdqsort] by Orson Peters, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link to
partial_cmp
please?