Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve messages for un-closed delimiter errors #53949

Merged
merged 4 commits into from
Sep 9, 2018
Merged

Improve messages for un-closed delimiter errors #53949

merged 4 commits into from
Sep 9, 2018

Commits on Sep 5, 2018

  1. Reword un-closed delimiter label

    @estebank
    estebank committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    5238b52 View commit details
    Browse the repository at this point in the history

  2. Provide more context for unenclosed delimiters 

     * When encountering EOF, point at the last opening brace that does not
   have the same indentation level as its close delimiter.
 * When encountering the wrong type of close delimiter, point at the
   likely correct open delimiter to give a better idea of what went
   wrong.
    @estebank
    estebank committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    008aa5a View commit details
    Browse the repository at this point in the history

  3. Fix existing test

    @estebank
    estebank committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    b2d2d83 View commit details
    Browse the repository at this point in the history

  4. Change wording of unclosed delimiter label

    @estebank
    estebank committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    3192d3d View commit details
    Browse the repository at this point in the history