Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely only on base alignment and offset for computing field alignment #54547

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Rely only on base alignment and offset for computing field alignment #54547

merged 1 commit into from
Sep 28, 2018

Conversation

AstralSorceress
Copy link
Contributor

@AstralSorceress AstralSorceress commented Sep 25, 2018 •
edited
Loading

Fix #54028
r? @eddyb

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2018
@AstralSorceress
Copy link
Contributor Author

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned nikomatsakis Sep 25, 2018
@eddyb
Copy link
Member

eddyb commented Sep 27, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Sep 27, 2018

📌 Commit 06b8c3e has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2018
@bors
Copy link
Contributor

bors commented Sep 28, 2018

⌛ Testing commit 06b8c3e with merge c222479...

bors added a commit that referenced this pull request Sep 28, 2018
@bors
Auto merge of #54547 - AstralSorcerer:issue-54028, r=eddyb
c222479 
Rely only on base alignment and offset for computing field alignment

Fix #54028
r? @eddyb
@bors
Copy link
Contributor

bors commented Sep 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing c222479 to master...

@bors bors merged commit 06b8c3e into rust-lang:master Sep 28, 2018
@glaubitz
Copy link
Contributor

This commit has caused a regression: #56927

The compiler is generating code with unaligned access.

@nagisa nagisa mentioned this pull request Dec 20, 2018
Closed
@RalfJung RalfJung mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AstralSorceress @rust-highfive @eddyb @bors @glaubitz @nikomatsakis