Add template parameter debuginfo to generic types #55010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Fails when built against LLVM 5 or 6, works when LLVM is built in-tree. |
tromey
force-pushed
the
Bug-9224-generic-parameters
branch
from
797f2ba to
670ea7b
Compare
|
Had to delay setting the type parameters until the struct was filled in; which makes sense, the mystery being why it failed with the in-tree LLVM. |
There was a problem hiding this comment.
Thanks, @tromey! Looks good. However, would it be possible to use a single replaceArrays() call to set both the members and the type parameters? Then you wouldn't have to add LLVMRustDIBuilderReplaceTemplateParams (just extend adapt LLVMRustDICompositeTypeSetTypeArray).
tromey
force-pushed
the
Bug-9224-generic-parameters
branch
from
670ea7b to
8a3bb9a
Compare
|
Rebased + tried to address review comments. Let me know what you think. |
|
Looks great, thank you! @bors r+ |
|
📌 Commit 8a3bb9a has been approved by |
bors
added
S-waiting-on-bors
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Oct 25, 2018
… r=michaelwoerister
Add template parameter debuginfo to generic types
This changes debuginfo generation to add template parameters to
generic types. With this change the DWARF now has
DW_TAG_template_type_param for types, not just for functions, like:
<2><40d>: Abbrev Number: 6 (DW_TAG_structure_type)
<40e> DW_AT_name : (indirect string, offset: 0x375): Generic<i32>
<412> DW_AT_byte_size : 4
<413> DW_AT_alignment : 4
...
<3><41f>: Abbrev Number: 8 (DW_TAG_template_type_param)
<420> DW_AT_type : <0x42a>
<424> DW_AT_name : (indirect string, offset: 0xa65e): T
Closes rust-lang#9224
|
⌛ Testing commit 8a3bb9a with merge 7c41b8c778b18bd9c6e4446bd876adc655c2702f... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
Failed to stage 1 libcore on |
kennytm
added
S-waiting-on-author
tromey
force-pushed
the
Bug-9224-generic-parameters
branch
from
8a3bb9a to
2a3f38b
Compare
|
@bors r+ |
|
📌 Commit 2a3f38bbff21cf2107b77d8051ff542095b7baca has been approved by |
|
⌛ Testing commit fb204cb with merge 4d3c2da893443aab6d006a629c4293a79004f8af... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors retry cc SIGILL again |
bors
added
S-waiting-on-bors
|
⌛ Testing commit fb204cb with merge 00663a917413b848ac252805de30df2a051a5630... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-bors
|
@bors p=47 |
bors
added a commit
that referenced
this pull request
Dec 3, 2018
…oerister
Add template parameter debuginfo to generic types
This changes debuginfo generation to add template parameters to
generic types. With this change the DWARF now has
DW_TAG_template_type_param for types, not just for functions, like:
<2><40d>: Abbrev Number: 6 (DW_TAG_structure_type)
<40e> DW_AT_name : (indirect string, offset: 0x375): Generic<i32>
<412> DW_AT_byte_size : 4
<413> DW_AT_alignment : 4
...
<3><41f>: Abbrev Number: 8 (DW_TAG_template_type_param)
<420> DW_AT_type : <0x42a>
<424> DW_AT_name : (indirect string, offset: 0xa65e): T
Closes #9224
|
☀️ Test successful - status-appveyor, status-travis |
|
This PR hurf performance on a few benchmarks, the worst by almost 5%. @tromey, any ideas how to ameliorate that? |
|
The patch itself is pretty straightforward. Unless that new function ( One possible idea is that, since this debug info is primarily useful for pretty-printers, perhaps it could be limited to types where the generic parameters do not appear in any of the fields. Offhand I do not know whether this can be cheaply decided. |
There were no slowdowns in |
|
Incremental builds are affected more than non-incremental ones. The reason for this might be explained by incr. comp. producing more object files which causes more type information to be duplicated (because type information can't be shared between object files in LLVM). No simple, immediate fix comes to mind, unfortunately. At least only builds with full debuginfo should be affected. Line-info-only builds should be fine. |
|
We should consider fixing this in LLVM. The problem is only going to get worse -- for example, I'd like to emit DWARF describing all the traits, which I imagine will result in much more IR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes debuginfo generation to add template parameters to
generic types. With this change the DWARF now has
DW_TAG_template_type_param for types, not just for functions, like:
<2><40d>: Abbrev Number: 6 (DW_TAG_structure_type)
<40e> DW_AT_name : (indirect string, offset: 0x375): Generic
<412> DW_AT_byte_size : 4
<413> DW_AT_alignment : 4
...
<3><41f>: Abbrev Number: 8 (DW_TAG_template_type_param)
<420> DW_AT_type : <0x42a>
<424> DW_AT_name : (indirect string, offset: 0xa65e): T
Closes #9224