Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "rustc: Fix (again) simd vectors by-val in ABI" #55281

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Revert "rustc: Fix (again) simd vectors by-val in ABI" #55281

merged 1 commit into from
Oct 23, 2018

Conversation

alexcrichton
Copy link
Member

This reverts commit 3cc8f73.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2018
@alexcrichton
Copy link
Member Author

I've discovered that #55073 causes segfaults in stdsimd'd CI. This reverts #55073 and while the four attached issues are all serious issues it looks like LLVM has an upstream patch which may solve it and is almost surely more correct than #55073.

I'm gonna reopen the requisite issues as well and we can hopefully re-close shortly therafter with an official fix from LLVM

@alexcrichton alexcrichton mentioned this pull request Oct 23, 2018
Merged
@alexcrichton
Copy link
Member Author

Also note that I haven't really bothered to try to dig into what is actually segfaulting, I'm assuming that the LLVM patch will likely land in the near future, allowing us to fix the bug at least within a month or so.

@alexcrichton
Copy link
Member Author

@bors: p=1

This was referenced Oct 23, 2018
Closed
Merged
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 23, 2018

📌 Commit 086f5a5 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2018
@bors
Copy link
Contributor

bors commented Oct 23, 2018

⌛ Testing commit 086f5a5 with merge d74b402...

bors added a commit that referenced this pull request Oct 23, 2018
@bors
Auto merge of #55281 - alexcrichton:revert-demote, r=petrochenkov
d74b402 
Revert "rustc: Fix (again) simd vectors by-val in ABI"

This reverts commit 3cc8f73.
@bors
Copy link
Contributor

bors commented Oct 23, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing d74b402 to master...

This was referenced Oct 23, 2018
Closed
Merged
@bors bors merged commit 086f5a5 into rust-lang:master Oct 23, 2018
@alexcrichton alexcrichton deleted the revert-demote branch November 1, 2018 15:25
@andersk andersk mentioned this pull request Dec 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexcrichton @rust-highfive @petrochenkov @bors