-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cargo new --edition
from release notes.
#55362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 25, 2018
@bors r+ p=1 (want to land before beta promotion, but feel free to rollup) |
📌 Commit 19c4e36 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 25, 2018
bors
added a commit
that referenced
this pull request
Oct 26, 2018
…acrum Remove `cargo new --edition` from release notes. This was removed at the last minute (#55315, rust-lang/cargo#6216). Apologies for not catching this.
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Oct 29, 2018
[beta]: Prepare the 1.31.0 beta release * Update to Cargo's branched 1.31.0 branch * Update the channel to `beta` Rolled up beta-accepted PRs: * #55362: Remove `cargo new --edition` from release notes. * #55325: Fix link to macros chapter * #55358: Remove redundant clone (2) * #55346: Shrink `Statement`. * #55274: Handle bindings in substructure of patterns with type ascriptions * #55297: Partial implementation of uniform paths 2.0 to land before beta * #55192: Fix ordering of nested modules in non-mod.rs mods * #55185: path suggestions in Rust 2018 should point out the change in semantics * #55423: back out bogus `Ok`-wrapping suggestion on `?` arm type mismatch Note that **this does not update the bootstrap compiler** due to #55404
pietroalbini
added
stable-nominated
Nominated for backporting to the compiler in the stable channel.
stable-accepted
Accepted for backporting to the compiler in the stable channel.
labels
Nov 1, 2018
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Nov 7, 2018
…ark-Simulacrum Remove `cargo new --edition` from release notes. This was removed at the last minute (rust-lang#55315, rust-lang/cargo#6216). Apologies for not catching this.
pietroalbini
added
stable-accepted
Accepted for backporting to the compiler in the stable channel.
and removed
stable-accepted
Accepted for backporting to the compiler in the stable channel.
stable-nominated
Nominated for backporting to the compiler in the stable channel.
labels
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
stable-accepted
Accepted for backporting to the compiler in the stable channel.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed at the last minute (#55315, rust-lang/cargo#6216).
Apologies for not catching this.