Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to token-tree-based parsing #5559

Closed

Conversation

jbclements
Copy link
Contributor

Changes the parser to parse all streams into token-trees before hitting the parser proper, in preparation for hygiene. As an added bonus, it appears to speed up the parser (albeit by a totally imperceptible 1%).

Also, many comments in the parser.
Also, field renaming in token-trees (readme->forest, cur->stack).

@thestinger
Copy link
Contributor

@jbclements: I think github orders the ones on the pull request page by the commit timestamps instead of being sane and using the parent relations like everywhere else.

bors added a commit that referenced this pull request Apr 3, 2013
…bclements

Changes the parser to parse all streams into token-trees before hitting the parser proper, in preparation for hygiene.  As an added bonus, it appears to speed up the parser (albeit by a totally imperceptible 1%).

Also, many comments in the parser.
Also, field renaming in token-trees (readme->forest, cur->stack).
@bors bors closed this Apr 3, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 5, 2020
… r=flip1995

Fix FP on while-let-on-iterator

- fix `is_refutable` for slice patterns
- fix `is_refutable` for bindings
- add some TODO-s for cases, which can not be fixed easily

fixes rust-lang#3780

changelog: fix FP on while-let-on-iterator for arrays and bindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants