-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bound types in librustc_traits
#55649
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #55859) made this pull request unmergeable. Please resolve the merge conflicts. |
d385039
to
40208ab
Compare
@@ -179,6 +179,30 @@ impl<'a, 'gcx, 'tcx> Substs<'tcx> { | |||
}) | |||
} | |||
|
|||
pub fn bound_vars_for_item( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to have a comment here.
Returns a substitution vector containing "identity references" suitable for converting from the compiler's parameter representation to the bound type representation used in Chalk. The Nth parameter is substituted to a bound variable of index N, pointing at the innermost binder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you added this later :)
@bors r+ |
📌 Commit 40208abdaae08e7c3ab89a167f086039ca9f6285 has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
40208ab
to
8d0b969
Compare
@bors r=nikomatsakis |
📌 Commit 8d0b969 has been approved by |
Use bound types in `librustc_traits` r? @nikomatsakis see the tests which now move the higher-ranked binders to the left in implied bound rules!
☀️ Test successful - status-appveyor, status-travis |
r? @nikomatsakis
see the tests which now move the higher-ranked binders to the left in implied bound rules!