rustc_target: pass contexts by reference, not value. #55665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Nov 3, 2018
|
@bors r+ |
|
📌 Commit d42d783863bda3a192e32e7c89d7779b4a76b093 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #55393) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
eddyb
force-pushed
the
by-ref-layout-of
branch
from
d42d783 to
d00d42d
Compare
|
📌 Commit d00d42d has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 4, 2018
rustc_target: pass contexts by reference, not value. `LayoutOf` now takes `&self` instead of `self`, and so does every method generic over a context that implements `LayoutOf` and/or other traits, like `HasDataLayout`, `HasTyCtxt`, etc. Originally using by-value `Copy` types was relevant because `TyCtxt` was one of those types, but now `TyCtxt::layout_of` is separate from `LayoutOf`, and `TyCtxt` is not an often used layout context. Passing these context by reference is a lot nicer for miri, which has `self: &mut EvalContext`, and needed `f(&self)` (that is, creating `&&mut EvalContext` references) for layout purposes. Now, the `&mut EvalContext` can be passed to a function expecting `&C`, directly. This should help with #54012 / #55627 (to not need `where &'a T::Cx: LayoutOf` bounds). r? @nikomatsakis or @oli-obk or @nagisa cc @sunfishcode
|
☀️ Test successful - status-appveyor, status-travis |
|
📣 Toolstate changed by #55665! Tested on commit e6c5cf9. 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Nov 4, 2018
Tested on commit rust-lang/rust@e6c5cf9. Direct link to PR: <rust-lang/rust#55665> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 rls on windows: test-pass → build-fail (cc @nrc @Xanewok, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @nrc @Xanewok, @rust-lang/infra).
matthiaskrgr
added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
Nov 4, 2018
bors bot
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Nov 4, 2018
3411: rustup rust-lang/rust#55665 (pass contexts by reference) r=matthiaskrgr a=matthiaskrgr Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 4, 2018
Fixes clippy toolstate. Changes: ```` rustup rust-lang#55665 (pass contexts by reference) Fix typo Improve clippy_dev help text RIIR update lints: Generate lint group registrations Test clippy_dev on CI and fix test RIIR update lints: Generate modules section ````
bors
added a commit
that referenced
this pull request
Nov 5, 2018
submodules: update clippy from 71ec4ff to d8b4269 Fixes clippy toolstate. Changes: ```` rustup #55665 (pass contexts by reference) Fix typo Improve clippy_dev help text RIIR update lints: Generate lint group registrations Test clippy_dev on CI and fix test RIIR update lints: Generate modules section ````
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 5, 2020
Fixes clippy toolstate. Changes: ```` rustup rust-lang/rust#55665 (pass contexts by reference) Fix typo Improve clippy_dev help text RIIR update lints: Generate lint group registrations Test clippy_dev on CI and fix test RIIR update lints: Generate modules section ````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayoutOfnow takes&selfinstead ofself, and so does every method generic over a context that implementsLayoutOfand/or other traits, likeHasDataLayout,HasTyCtxt, etc.Originally using by-value
Copytypes was relevant becauseTyCtxtwas one of those types, but nowTyCtxt::layout_ofis separate fromLayoutOf, andTyCtxtis not an often used layout context.Passing these context by reference is a lot nicer for miri, which has
self: &mut EvalContext, and neededf(&self)(that is, creating&&mut EvalContextreferences) for layout purposes.Now, the
&mut EvalContextcan be passed to a function expecting&C, directly.This should help with #54012 / #55627 (to not need
where &'a T::Cx: LayoutOfbounds).r? @nikomatsakis or @oli-obk or @nagisa cc @sunfishcode