Clarifying documentation for collections::hash_map::Entry::or_insert #55784
Conversation
Previous version does not show that or_insert does not insert the passed value, as the passed value was the same value as what was already in the map.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Thanks @meltinglava! Hm, maybe we could make it even clearer by picking a completely different number than either |
|
I agree. I slept on it and have found that the goal is that the numbers in them self should be not to different (distracting) while yet be different enought. Also I think that using |
|
Now this version is the one that i found the easyiest. |
|
Looks good to me! Thanks @meltinglava @bors r+ rollup |
|
📌 Commit 8b750a7 has been approved by |
bors
added
S-waiting-on-bors
Clarifying documentation for collections::hash_map::Entry::or_insert Previous version does not show that or_insert does not insert the passed value, as the passed value was the same value as what was already in the map.
Rollup of 11 pull requests Successful merges: - #55367 (lint if a private item has doctests) - #55485 (Return &T / &mut T in ManuallyDrop Deref(Mut) impl) - #55784 (Clarifying documentation for collections::hash_map::Entry::or_insert) - #55961 (Fix VecDeque pretty-printer) - #55980 (Suggest on closure args count mismatching with pipe span) - #56002 (fix #55972: Erroneous self arguments on bare functions emit subpar compilation error) - #56063 (Update any.rs documentation using keyword dyn) - #56067 (Add SGX target to rustc) - #56078 (Fix error message for `-C panic=xxx`.) - #56106 (Remove some incorrect doc comments) - #56126 (core/benches/num: Add `from_str/from_str_radix()` benchmarks) Failed merges: r? @ghost
Previous version does not show that or_insert does not insert the passed value, as the passed value was the same value as what was already in the map.