Fix TLS errors when downloading stage0 #55840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Did something change recently on Windows? I never had this problem before, but now I am unable to build without this patch. |
|
Thanks for the PR! I suspect that this may have actually had to do with a recent TLS configuration change maybe? Some googling seems to show that TLS 1.2 isn't always enabled by default on Windows. Could this URL perhaps be tried out? We may just need to update the powershell snippet here to include that. We've had some bad luck in the past with Python's urllib, so if we can stick to PowerShell that'd be best! |
|
I can confirm that adding |
dlrobertson
force-pushed
the
fix_stage0_download
branch
2 times, most recently
from
d4283e6 to
c211238
Compare
|
@alexcrichton @ehuss Updated to use powershell. |
|
@bors: r+ rollup Thanks! |
|
📌 Commit c211238 has been approved by |
bors
added
S-waiting-on-bors
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Nov 12, 2018
…alexcrichton Fix TLS errors when downloading stage0 While attempting to test rust-lang#49878 on Windows I hit the following error when attempting to download stage0. ``` The request was aborted: Could not create SSL/TLS secure channel ``` Instead of using the shell, we can just use `urllib`, which seems to fix the issue.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 13, 2018
…alexcrichton Fix TLS errors when downloading stage0 While attempting to test rust-lang#49878 on Windows I hit the following error when attempting to download stage0. ``` The request was aborted: Could not create SSL/TLS secure channel ``` Instead of using the shell, we can just use `urllib`, which seems to fix the issue.
bors
added a commit
that referenced
this pull request
Nov 13, 2018
Rollup of 20 pull requests Successful merges: - #55136 (Remove short doc where it starts with a codeblock) - #55711 (Format BtreeMap::range_mut example) - #55722 (impl_stable_hash_for: support enums and tuple structs with generic parameters) - #55754 (Avoid converting bytes to UTF-8 strings to print, just pass bytes to stdout/err) - #55804 (rustdoc: don't inline `pub use some_crate` unless directly asked to) - #55805 (Move `static_assert!` into librustc_data_structures) - #55837 (Make PhantomData #[structural_match]) - #55840 (Fix TLS errors when downloading stage0) - #55843 (add FromIterator<A> to Box<[A]>) - #55858 (Small fixes on code blocks in rustdoc) - #55863 (Fix a typo in std::panic) - #55870 (Fix typos.) - #55874 (string: Add documentation for `From` impls) - #55879 (save-analysis: Don't panic for macro-generated use globs) - #55882 (Reference count `crate_inherent_impls`s return value.) - #55888 (miri: for uniformity, also move memory_deallocated to AllocationExtra) - #55889 (global allocators: add a few comments) - #55896 (Document optimizations enabled by FusedIterator) - #55905 (Change `Lit::short_name` to `Lit::literal_name`.) - #55908 (Fix their/there grammar nit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to test #49878 on Windows I hit the following error when attempting to download stage0.
Instead of using the shell, we can just use
urllib, which seems to fix the issue.