librustc: Remove fail_unless!
#5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Mar 29, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 27, 2020
…eversed_empty_ranges, r=phansch reversed_empty_ranges: add suggestion for &slice[N..N] As discussed in the issue thread, the user accepted this solution. Let me know if this is what we want, or if changing the way we lint the N..N case is prefered. changelog: reversed_empty_ranges: add suggestion for &slice[N..N] Closes rust-lang#5628
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 12, 2023
…or` loop. Reading the documentation for the lint, one could expect that the lint works in all cases that `X == Y`. This is false. While the lint was updated, the documentation wasn't. More information about the `N..N` problem in rust-lang#5689 and rust-lang#5628
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 12, 2023
…dswij [rust-lang#10167] Clarify that the lint only works if x eq. y in a `for` loop. Reading the documentation for the lint, one could expect that the lint works in all cases that `X == Y`. This is false. While the lint was updated, the documentation wasn't. More information about the `N..N` problem in rust-lang#5689 and rust-lang#5628 --- Fixes rust-lang#10167 changelog: [`reversed_empty_ranges`]: Update and clarify documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.