-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serialize: rename to rustc_serialize. #56323
Conversation
@bors try |
⌛ Trying commit 494fc3a009984ed6f9b91cd3c665cddcb23804e3 with merge 267cf972c7141a79f125d2b66cecd6ce43b7226a... |
@rust-lang/infra Whenever nobody else needs crater, a |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@bors try |
⌛ Trying commit 8e10efa8683dfc0c255f0ab2d8efc43a5045dee7 with merge 5bdcd57ba31b39cdfb189318f63a9c55c13cb3b6... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@bors try |
[WIP] serialize: rename to rustc_serialize. In preparation for post-#49219 use of custom derives in rustc, we'll want to stop using `Rustc{Encodable,Decodable}` derives, and *at least* adapt the library to suit `rustc` better, before a full implementation of #36588 can be done. This will break anyone using `extern crate serialize;` (on nightly) so let's do a crater run with a rename, just to see what things are like. **EDIT**: I was going to test with `rustc_serialize` (which does work in terms of compiling) but I realized that `rustc-serialize` from crates.io might make that tricky if it ends up in our sysroot, so for the crater run let's go with something weirder (`rustc_ezilaires`). **EDIT2**: had to remove `rustc_save_analysis` and `rls` to get rid of the crates.io `rustc-serialize` from Cargo.lock. Note that this is just for crater, just like the `rustc_ezilaires` rename. r? @nikomatsakis
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@bors try |
⌛ Trying commit d84236bf123e1adfc8d8d64a6a0071039b16a554 with merge 32252761328f59ccfadb1bafb8148c685bc830b3... |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
OMG this is such an exciting concept |
🎉 Experiment
|
Only one regression from using |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
(I need to either move the test to a |
@bors r+ |
📌 Commit d76e861 has been approved by |
Er, @bors r- |
r=me but I see travis is unhappy? (To confirm: this affects only nightly users, and we only found 1 of those on the crater run, right?) |
@nikomatsakis Yeah, everyone else is using the out-of-tree |
☔ The latest upstream changes (presumably #55635) made this pull request unmergeable. Please resolve the merge conflicts. |
Triage; @eddyb Hello, have you been able to get back to this PR? |
Ping from triage @eddyb: What is the status of this PR? |
ping from triage @eddyb Unfortunately we haven't heard from you on this in a while, so I'm closing the PR to keep things tidy. Don't worry though, if you'll have time again in the future please reopen this PR, we'll be happy to review it again! |
In preparation for post-#49219 use of custom derives in rustc, we'll want to stop using
Rustc{Encodable,Decodable}
derives, and at least adapt the library to suitrustc
better, before a full implementation of #36588 can be done.This will break anyone using
extern crate serialize;
(on nightly) so let's do a crater run with a rename, just to see what things are like.EDIT: I was going to test withrustc_serialize
(which does work in terms of compiling) but I realized thatrustc-serialize
from crates.io might make that tricky if it ends up in our sysroot, so for the crater run let's go with something weirder (rustc_ezilaires
).EDIT2: had to removerustc_save_analysis
andrls
to get rid of the crates.iorustc-serialize
from Cargo.lock. Note that this is just for crater, just like therustc_ezilaires
rename.EDIT3: cleaned up the PR, after crate run shows only one regression.
r? @nikomatsakis