-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 14 pull requests #56437
Rollup of 14 pull requests #56437
Conversation
…especting inhabitedness checks
We've seen sporadic QE failures in the timeout tests on this assertion: assert!(kind == ErrorKind::WouldBlock || kind == ErrorKind::TimedOut); So there's an error, but not either of the expected kinds. Adding a format to show the kind revealed `ErrorKind::Interrupted` (`EINTR`). For the cases that were using `read`, we can just use `read_exact` to keep trying after interruption. For those using `recv_from`, we have to manually loop until we get a non-interrupted result.
The previous one didn't actually use the Display&Debug bounds in any way, so I think this one is a bit more meaningful.
…cramertj Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks It isn't settled exactly how references to uninhabited types and unions of uninhabited types should act, but we should be more conservative here, as it's likely it will be permitted to soundly have values of such types. This will also be more important in light of the changes at rust-lang#54125. cc @RalfJung
update miri This should make miri green again :) (Includes rust-lang/miri#553) r? @oli-obk
… r=Centril Stabilize self_in_typedefs feature [**Tracking Issue**](rust-lang#49303) r? @Centril
…ref, r=davidtwco Refer to the second borrow as the "second borrow" in E0501.rs Fixes rust-lang#55314. r? @davidtwco
…kler Deal with EINTR in net timeout tests We've seen sporadic QE failures in the timeout tests on this assertion: assert!(kind == ErrorKind::WouldBlock || kind == ErrorKind::TimedOut); So there's an error, but not either of the expected kinds. Adding a format to show the kind revealed `ErrorKind::Interrupted` (`EINTR`). For the cases that were using `read`, we can just use `read_exact` to keep trying after interruption. For those using `recv_from`, we have to manually loop until we get a non-interrupted result.
…nSapin Stabilize dbg!(...) Per FCP in rust-lang#54306 (which is ~1 day from completion). r? @SimonSapin The PR is fairly isolated so a rollup should probably work.
…olnay Move VecDeque::resize_with out of the impl<T:Clone> block I put this in the wrong `impl` block in rust-lang#56016, so fixing. Tracking issue for the unstable method: rust-lang#41758 (comment)
…e, r=Centril Improve the unstable book example for #[marker] trait The previous one didn't actually use the Display&Debug bounds in any way, so I think this one is a bit more meaningful.
Update tracking issue for `extern_crate_self`
…dreavus Remove unneeded body class selector r? @QuietMisdreavus
Fix failing tidy (line endings on Windows) Updates to `rustc-guide` and `edition-guide` including rust-lang/rustc-dev-guide#246 and rust-lang/edition-guide#122.
Remove some uses of try!
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
Update issue number of `shrink_to` methods to point the tracking issue Tracking issue: rust-lang#56431
📌 Commit c03c34c has been approved by |
Rollup of 14 pull requests Successful merges: - #56110 (Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks) - #56305 (update miri) - #56366 (Stabilize self_in_typedefs feature) - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs) - #56394 (Deal with EINTR in net timeout tests) - #56395 (Stabilize dbg!(...)) - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block) - #56402 (Improve the unstable book example for #[marker] trait) - #56412 (Update tracking issue for `extern_crate_self`) - #56416 (Remove unneeded body class selector) - #56418 (Fix failing tidy (line endings on Windows)) - #56419 (Remove some uses of try!) - #56424 (Mention raw-ident syntax) - #56432 (Update issue number of `shrink_to` methods to point the tracking issue) Failed merges: r? @ghost
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Successful merges:
extern_crate_self
#56412 (Update tracking issue forextern_crate_self
)shrink_to
methods to point the tracking issue #56432 (Update issue number ofshrink_to
methods to point the tracking issue)Failed merges:
r? @ghost