Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate unsatisfied trait bounds #56760

Merged
merged 2 commits into from
Dec 15, 2018
Merged

Conversation

estebank
Copy link
Contributor

Fix #35677.

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2018
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit.

src/librustc_typeck/check/method/suggest.rs Outdated Show resolved Hide resolved
Co-Authored-By: estebank <estebank@users.noreply.github.com>
@alexreg
Copy link
Contributor

alexreg commented Dec 13, 2018

Is this related to my ongoing PR #55994 (specifically point 3)?

@oli-obk
Copy link
Contributor

oli-obk commented Dec 13, 2018

I don't think so, this PR relates to collecting duplicates while producing a diagnostic. This can happen if bounds exist on an impl block and on a function

@estebank
Copy link
Contributor Author

@bors r=oli-obk rollup

@bors
Copy link
Contributor

bors commented Dec 13, 2018

📌 Commit a39f184 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Dec 14, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Dec 14, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 14, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 15, 2018
bors added a commit that referenced this pull request Dec 15, 2018
Rollup of 14 pull requests

Successful merges:

 - #56718 (Use libbacktrace pretty-printing)
 - #56725 (fix rust-lang/rust issue #50583)
 - #56731 (Add missing urls in ffi module docs)
 - #56738 (Fix private_no_mangle_fns message grammar)
 - #56746 (Add test of current behavior (infer free region within closure body))
 - #56747 (target: remove Box returned by get_targets)
 - #56751 (Allow ptr::hash to accept fat pointers)
 - #56755 (Account for `impl Trait` when suggesting lifetime)
 - #56758 (Add short emoji status to toolstate updates)
 - #56760 (Deduplicate unsatisfied trait bounds)
 - #56769 (Add x86_64-unknown-uefi target)
 - #56792 (Bootstrap: Add testsuite for compiletest tool)
 - #56808 (Fixes broken links)
 - #56809 (Fix docs path to PermissionsExt)

Failed merges:

r? @ghost
@bors bors merged commit a39f184 into rust-lang:master Dec 15, 2018
@estebank estebank deleted the dedup-bounds branch November 9, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants