Rollup of 32 pull requests #56775

kennytm · 2018-12-13T12:54:42Z

Successful merges:

[std] Osstr lossy example #56142 ([std] Osstr lossy example)
Add lint for items deprecated in future #56203 (Add lint for items deprecated in future)
Remove not used mod #56343 (Remove not used mod)
Stabilize linker-flavor flag. #56351 (Stabilize linker-flavor flag.)
Clearer error message for dead assign #56439 (Clearer error message for dead assign)
polonius tweaks #56507 (polonius tweaks)
Update libc version required by rustc #56562 (Update libc version required by rustc)
bootstrap: fix edition #56600 (bootstrap: fix edition)
Unconditionally emit the target-cpu LLVM attribute. #56609 (Unconditionally emit the target-cpu LLVM attribute.)
rustdoc: Fix local reexports of proc macros #56637 (rustdoc: Fix local reexports of proc macros)
Add non-panicking maybe_new_parser_from_file variant #56658 (Add non-panicking maybe_new_parser_from_file variant)
Document time of back operations of a Linked List #56672 (Document time of back operations of a Linked List)
#[must_use] on traits in stdlib #56677 (#[must_use] on traits in stdlib)
overhaul external doc attribute diagnostics #56679 (overhaul external doc attribute diagnostics)
fix install broken link #56691 (fix install broken link)
Fix irrefutable matches on integer ranges #56695 (Fix irrefutable matches on integer ranges)
Use a newtype_index! within Symbol. #56699 (Use a newtype_index! within Symbol.)
[self-profiler] Add column for percent of total time #56702 ([self-profiler] Add column for percent of total time)
Remove some unnecessary feature gates #56708 (Remove some unnecessary feature gates)
Always set the RDRAND and RDSEED features on SGX #56710 (Always set the RDRAND and RDSEED features on SGX)
Test capacity of ZST vector #56713 (Test capacity of ZST vector)
Use libbacktrace pretty-printing #56718 (Use libbacktrace pretty-printing)
fix rust-lang/rust issue #50583 #56725 (fix rust-lang/rust issue Getting a Illegal instruction segfault on arm (Raspberry Pi 1) #50583)
Add missing urls in ffi module docs #56731 (Add missing urls in ffi module docs)
Fix private_no_mangle_fns message grammar #56738 (Fix private_no_mangle_fns message grammar)
infer: remove Box from a returned Iterator #56742 (infer: remove Box from a returned Iterator)
Add test of current behavior (infer free region within closure body) #56746 (Add test of current behavior (infer free region within closure body))
target: remove Box returned by get_targets #56747 (target: remove Box returned by get_targets)
x86: Add the adx target feature to whitelist #56749 (x86: Add the adx target feature to whitelist)
Account for impl Trait when suggesting lifetime #56755 (Account for impl Trait when suggesting lifetime)
Disable btree pretty-printers on older gdbs #56756 (Disable btree pretty-printers on older gdbs)
Add short emoji status to toolstate updates #56758 (Add short emoji status to toolstate updates)

`mir_stats` mod has not been used since c1ff104.

Filter out `ProcMacroStub`s to avoid an ICE during cleaning. Also add proc macros to `cache().paths` so it can generate links.

@bors

Popping and pushing from the end of a linked list is constant time. This documentation is already there for popping and pushing from the front. @bors: r+ 38fe8d2 rollup

Also, provide a suggestion for the correct syntax.

Initially, rust-lang#50233 accidentally changed the capacity of empty ZST. This was pointed out during code review. This commit adds a test to prevent capacity of ZST vectors from accidentally changing to prevent that from happening again.

bors · 2018-12-13T13:00:05Z

📌 Commit 055e288 has been approved by kennytm

…ker-flavor, r=nagisa Stabilize `linker-flavor` flag. Part of rust-lang#55396. This commit moves the linker-flavor flag from a debugging option to a codegen option, thus stabilizing it. There are no feature flags associated with this flag.

… r=kennytm Add short emoji status to toolstate updates I get a lot of these emails and it's good to know which ones I should be paying closer attention to -- i.e. the ones where clippy breaks. This adds a short emoji status report to the first line of the commit message, which shows up in notifications directly I haven't been able to test it, and the actual emoji are just suggestions.

kennytm · 2018-12-13T16:07:27Z

@bors r+

Added #56351, #56758.

bors · 2018-12-13T16:07:27Z

📌 Commit 8caa657 has been approved by kennytm

kennytm · 2018-12-13T16:26:50Z

@bors r+

Added #56783, #56490

bors · 2018-12-13T16:26:51Z

📌 Commit d05956190581cdf14dca91eb2f56821695b06215 has been approved by kennytm

bors · 2018-12-13T16:32:39Z

⌛ Testing commit d05956190581cdf14dca91eb2f56821695b06215 with merge 2353402c413985843641c4e23df6b0310b6d8a52...

bors · 2018-12-13T17:38:13Z

💔 Test failed - status-travis

kennytm · 2018-12-13T18:44:48Z

@bors r+

Removed #56783 (already testing)
Removed #56490 (causing the error above)

bors · 2018-12-13T18:44:48Z

📌 Commit 8caa657 has been approved by kennytm

bors · 2018-12-13T20:21:12Z

⌛ Testing commit 8caa657 with merge ab187f7479c89404d9d6a44a5cb88eb3c21ac797...

bors · 2018-12-13T21:48:13Z

💔 Test failed - status-travis

rust-highfive · 2018-12-13T21:48:15Z

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:24:39]                                                         ^^^^^^^^^^^^
[01:24:39]     = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[01:24:39] 
[01:24:40]  Documenting arena v0.0.0 (/checkout/src/libarena)
[01:24:41] thread '<unnamed>' panicked at 'assertion failed: output.is_none()', src/librustdoc/clean/simplify.rs:108:21
[01:24:41] 
[01:24:41] error: internal compiler error: unexpected panic
[01:24:41] 
[01:24:41] error: Unrecognized option: 'document-private-items'
[01:24:41] error: Unrecognized option: 'document-private-items'
[01:24:41] 
[01:24:41] error: Could not document `rustc_codegen_llvm`.
[01:24:41] 
[01:24:41] Caused by:
[01:24:41]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --crate-name rustc_codegen_llvm src/librustc_codegen_llvm/lib.rs --color always --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/doc -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/release/deps --extern cc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/libcc-c6f14bfbea71a5d2.rmeta --extern memmap=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/libmemmap-f1ce0e7d8602fc1f.rmeta --extern num_cpus=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/libnum_cpus-2f51f01ec1efde74.rmeta --extern rustc_demangle=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_demangle-d7f65c515e37a89e.rmeta --extern rustc_llvm=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_llvm-98200b85279ce65f.rmeta --document-private-items` (exit code: 1)
[01:24:42] [RUSTC-TIMING] rustc_target test:false 4.272
[01:24:44] error: build failed
[01:24:44] 
[01:24:44] 
[01:24:44] 
[01:24:44] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "doc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--no-deps" "-p" "rustc" "-p" "rustc_codegen_ssa" "-p" "syntax_pos" "-p" "rustc_apfloat" "-p" "rustc_mir" "-p" "graphviz" "-p" "serialize" "-p" "rustc_typeck" "-p" "rustc_errors" "-p" "rustc_plugin" "-p" "fmt_macros" "-p" "rustc_fs_util" "-p" "rustc_save_analysis" "-p" "rustc_target" "-p" "rustc_driver" "-p" "syntax_ext" "-p" "rustc_llvm" "-p" "rustc_data_structures" "-p" "rustc_allocator" "-p" "rustc_privacy" "-p" "rustc_borrowck" "-p" "syntax" "-p" "rustc_platform_intrinsics" "-p" "arena" "-p" "rustc_resolve" "-p" "rustc_passes" "-p" "rustc_codegen_llvm" "-p" "rustc_incremental" "-p" "rustc_metadata" "-p" "rustc_codegen_utils" "-p" "rustc_lint" "-p" "build_helper" "-p" "rustc_traits"
[01:24:44] 
[01:24:44] 
[01:24:44] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
[01:24:44] Build completed unsuccessfully in 1:19:46
---
travis_time:end:033626c3:start=1544737670285052753,finish=1544737670291532419,duration=6479666
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0059858a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:086109e2
travis_time:start:086109e2
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:15736908
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2018-12-14T03:08:41Z

☔ The latest upstream changes (presumably #56351) made this pull request unmergeable. Please resolve the merge conflicts.

yui-knk and others added 30 commits November 29, 2018 08:54

Remove not used mod

934e4d3

`mir_stats` mod has not been used since c1ff104.

Clearer error message for dead assign

eaeebb5

Fix line length

54026c1

Fix stderr files

4cf5702

Fix stderr file (unused variable)

70536d4

Change to give a help message

c0e3f4b

Unconditionally emit the target-cpu LLVM attribute.

86822eb

rustdoc: Fix local reexports of proc macros

0bb075f

Filter out `ProcMacroStub`s to avoid an ICE during cleaning. Also add proc macros to `cache().paths` so it can generate links.

Add lint for items deprecated in future

aa04285

Add missing, non-panicking maybe_new_parser_from_file variant

85b50d0

Document time of back operations of a Linked List

562f33b

Popping and pushing from the end of a linked list is constant time. This documentation is already there for popping and pushing from the front. @bors: r+ 38fe8d2 rollup

bootstrap: fix edition

a5a3da5

Add test to check library traits have #[must_use] attribute

a336228

Add #[must_use] attribute to stdlib traits

ecc4ca5

Add trailing newline

3246f49

reject invalid external doc attributes

c3c2de9

Also, provide a suggestion for the correct syntax.

improve diagnostics for invalid external docs

7f7045f

fix install broken link

3d23e55

Add lint for stlib

f8c03b6

[self-profiler] Add column for percent of total time

771e8b8

Remove unnecessary feature gates from const fns

799cadb

Remove some dead code from sgx

1346619

Properly stage new feature gates

5457b19

Fix irrefutable matches on integer ranges

510a9ff

generate invalidations from 2-phase-borrow activations

30f531b

adopt polonius-engine 0.6.1

8ee2c06

Test capacity of ZST vector

1006425

Initially, rust-lang#50233 accidentally changed the capacity of empty ZST. This was pointed out during code review. This commit adds a test to prevent capacity of ZST vectors from accidentally changing to prevent that from happening again.

Always set the RDRAND and RDSEED features on SGX

5acab2d

miri: use backtrace crate printing instead of rolling our own

45b97f2

fix rust-lang/rust issue rust-lang#50583

b17a3f2

kennytm changed the title ~~Rollup of 29 pull requests~~ Rollup of 30 pull requests Dec 13, 2018

kennytm added 2 commits December 14, 2018 00:06

kennytm changed the title ~~Rollup of 30 pull requests~~ Rollup of 32 pull requests Dec 13, 2018

kennytm changed the title ~~Rollup of 32 pull requests~~ Rollup of 34 pull requests Dec 13, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 13, 2018

kennytm force-pushed the rollup branch from d059561 to 8caa657 Compare December 13, 2018 18:44

kennytm changed the title ~~Rollup of 34 pull requests~~ Rollup of 32 pull requests Dec 13, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 13, 2018

kennytm closed this Dec 14, 2018

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 32 pull requests #56775

Rollup of 32 pull requests #56775

kennytm commented Dec 13, 2018 •

edited

Loading

bors commented Dec 13, 2018

kennytm commented Dec 13, 2018

bors commented Dec 13, 2018

kennytm commented Dec 13, 2018

bors commented Dec 13, 2018

bors commented Dec 13, 2018

bors commented Dec 13, 2018

kennytm commented Dec 13, 2018

bors commented Dec 13, 2018

bors commented Dec 13, 2018

bors commented Dec 13, 2018

rust-highfive commented Dec 13, 2018

bors commented Dec 14, 2018

Rollup of 32 pull requests #56775

Rollup of 32 pull requests #56775

Conversation

kennytm commented Dec 13, 2018 • edited Loading

bors commented Dec 13, 2018

kennytm commented Dec 13, 2018

bors commented Dec 13, 2018

kennytm commented Dec 13, 2018

bors commented Dec 13, 2018

bors commented Dec 13, 2018

bors commented Dec 13, 2018

kennytm commented Dec 13, 2018

bors commented Dec 13, 2018

bors commented Dec 13, 2018

bors commented Dec 13, 2018

rust-highfive commented Dec 13, 2018

bors commented Dec 14, 2018

kennytm commented Dec 13, 2018 •

edited

Loading