-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#56411 do not suggest a fix for a import conflict in a macro #56937
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
macro_rules! import { | ||
( $($name:ident),* ) => { | ||
$( | ||
mod $name; | ||
pub use self::$name; | ||
//~^ ERROR the name `issue_56411` is defined multiple times | ||
//~| ERROR `issue_56411` is private, and cannot be re-exported | ||
|
||
)* | ||
} | ||
} | ||
|
||
import!(issue_56411); | ||
|
||
fn main() { | ||
println!("Hello, world!"); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
error[E0255]: the name `issue_56411` is defined multiple times | ||
--> $DIR/issue-56411.rs:5:21 | ||
| | ||
LL | mod $name; | ||
| ---------- previous definition of the module `issue_56411` here | ||
LL | pub use self::$name; | ||
| ^^^^^^^^^^^ | ||
| | | ||
| `issue_56411` reimported here | ||
| you can use `as` to change the binding name of the import | ||
... | ||
LL | import!(issue_56411); | ||
| --------------------- in this macro invocation | ||
| | ||
= note: `issue_56411` must be defined only once in the type namespace of this module | ||
|
||
error[E0365]: `issue_56411` is private, and cannot be re-exported | ||
--> $DIR/issue-56411.rs:5:21 | ||
| | ||
LL | pub use self::$name; | ||
| ^^^^^^^^^^^ re-export of private `issue_56411` | ||
... | ||
LL | import!(issue_56411); | ||
| --------------------- in this macro invocation | ||
| | ||
= note: consider declaring type or module `issue_56411` with `pub` | ||
|
||
error: aborting due to 2 previous errors | ||
|
||
Some errors occurred: E0255, E0365. | ||
For more information about an error, try `rustc --explain E0255`. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
// compile-pass | ||
|
||
struct T {} | ||
|
||
fn main() {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These files usually go in an There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, but There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you rename the file into something less subtle than "same file, but with underscore", e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you rely on
source.span.hi().0 - binding.span.lo().0
being a valid index inbinding.span
, then you should check at least the next conditions -!source.span.is_dummy() && !binding.span.is_dummy() && !from_macro(source.span) && !from_macro(binding.span)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, directly checking that
source.span.hi().0 - binding.span.lo().0
doesn't underflow and results in a valid index intocm
would be the most reliable alternative.This way we certainly don't get an ICE, but also keep the diagnostics for "good" macros.