Use correct tracking issue for c_variadic #57340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit d39e15000b716468ba5970bc4ac3758e14ea8b94 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 5, 2019
Rollup of 17 pull requests Successful merges: - #57219 (Remove some unused code) - #57229 (Fix #56806 by using `delay_span_bug` in object safety layout sanity checks) - #57233 (Rename and fix nolink-with-link-args test) - #57238 (Fix backtraces for inlined functions on Windows) - #57249 (Fix broken links to second edition TRPL.) - #57267 (src/jemalloc is gone, remove its mention from COPYRIGHT) - #57273 (Update the stdsimd submodule) - #57278 (Add Clippy to config.toml.example) - #57295 (Fix 'be be' constructs) - #57311 (VaList::copy should not require a mutable ref) - #57312 (`const fn` is no longer coming soon (const keyword docs)) - #57313 (Improve Box<T> -> Pin<Box<T>> conversion) - #57314 (Fix repeated word typos) - #57326 (Doc rewording, use the same name `writer`) - #57338 (rustdoc: force binary filename for compiled doctests) - #57342 (librustc_mir: Make qualify_min_const_fn module public) - #57343 (Calculate privacy access only via query) Failed merges: - #57340 (Use correct tracking issue for c_variadic) r? @ghost
|
☔ The latest upstream changes (presumably #57354) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
Ping from triage @eqrion Have you been able to make any progress on this PR? |
|
Apologies, I forgot about this. @stokhos Merging was blocked on conflicts, I rebased past them so it should be good to merge again. Not sure if there's something I need to do to trigger this. |
|
@bors r+ rollup |
|
📌 Commit 6c60662 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 17, 2019
…acrum Use correct tracking issue for c_variadic Fixes rust-lang#57306
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 17, 2019
…acrum Use correct tracking issue for c_variadic Fixes rust-lang#57306
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 17, 2019
…acrum Use correct tracking issue for c_variadic Fixes rust-lang#57306
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 18, 2019
…acrum Use correct tracking issue for c_variadic Fixes rust-lang#57306
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 18, 2019
…acrum Use correct tracking issue for c_variadic Fixes rust-lang#57306
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 18, 2019
…acrum Use correct tracking issue for c_variadic Fixes rust-lang#57306
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 18, 2019
…acrum Use correct tracking issue for c_variadic Fixes rust-lang#57306
bors
added a commit
that referenced
this pull request
Jan 18, 2019
Rollup of 10 pull requests Successful merges: - #56594 (Remove confusing comment about ideally using `!` for `c_void`) - #57340 (Use correct tracking issue for c_variadic) - #57357 (Cleanup PartialEq docs.) - #57551 (resolve: Add a test for issue #57539) - #57636 (Fix sources sidebar not showing up) - #57646 (Fixes text becoming invisible when element targetted) - #57654 (Add some links in std::fs.) - #57683 (Document Unpin in std::prelude documentation) - #57685 (Enhance `Pin` impl applicability for `PartialEq` and `PartialOrd`.) - #57710 (Fix non-clickable urls) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57306