rustc: Remove platform intrinsics crate #57416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
cc @nagisa |
|
cc @rust-lang/compiler just so it does not go through without anybody noticing. @bors r+ |
|
📌 Commit 22481e603766ac42f3bf07940205e42029005c22 has been approved by |
bors
added
S-waiting-on-bors
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
alexcrichton
force-pushed
the
remove-platform-intrinsics
branch
from
22481e6 to
f00f9eb
Compare
|
@bors: r=nagisa |
|
📌 Commit f00f9ebe8e12c68de01ed83fa06224ca9007b81c has been approved by |
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
bors
added
S-waiting-on-author
alexcrichton
force-pushed
the
remove-platform-intrinsics
branch
from
f00f9eb to
3ddfdb8
Compare
|
@bors: r=nagisa |
|
📌 Commit 3ddfdb8a5d8c1fc1b96c24d850d4890c1f354b14 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #51487) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
This was originally attempted in rust-lang#57048 but it was realized that we could fully remove the crate via the `"unadjusted"` ABI on intrinsics. This means that all intrinsics in stdsimd are implemented directly against LLVM rather than using the abstraction layer provided here. That ends up meaning that this crate is no longer used at all. This crate developed long ago to implement the SIMD intrinsics, but we didn't end up using it in the long run. In that case let's remove it!
alexcrichton
force-pushed
the
remove-platform-intrinsics
branch
from
3ddfdb8 to
7616daa
Compare
|
@bors: r=nagisa |
|
📌 Commit 7616daa has been approved by |
bors
removed
the
S-waiting-on-author
|
⌛ Testing commit 7616daa with merge 2b32ed1289c57a3bb1516c6afbba868a066adbce... |
|
@bors: retry |
|
⌛ Testing commit 7616daa with merge 99dbd8b6c7131e112a93f6aa5514d5dce481d89e... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@bors: retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 7616daa with merge 7077898d88b9a69ffd3e56497a677a9b489ca5ff... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jan 16, 2019
rustc: Remove platform intrinsics crate This was originally attempted in #57048 but it was realized that we could fully remove the crate via the `"unadjusted"` ABI on intrinsics. This means that all intrinsics in stdsimd are implemented directly against LLVM rather than using the abstraction layer provided here. That ends up meaning that this crate is no longer used at all. This crate developed long ago to implement the SIMD intrinsics, but we didn't end up using it in the long run. In that case let's remove it!
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Jan 16, 2019
This was referenced Jan 21, 2019
|
It's really sad to me that we've made this step backwards from a somewhat-declarative notion of platform intrinsics to hardcoding LLVM's particular interface to them.
RLS, to some extent, also suffers from similar effects, but it doesn't directly feed back into the language itself, like cc @rust-lang/compiler @rust-lang/core |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally attempted in #57048 but it was realized that we
could fully remove the crate via the
"unadjusted"ABI on intrinsics.This means that all intrinsics in stdsimd are implemented directly
against LLVM rather than using the abstraction layer provided here. That
ends up meaning that this crate is no longer used at all.
This crate developed long ago to implement the SIMD intrinsics, but we
didn't end up using it in the long run. In that case let's remove it!