Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RELEASES.md for 1.32.0 #57471

Merged
merged 5 commits into from
Jan 11, 2019
Merged

Updated RELEASES.md for 1.32.0 #57471

merged 5 commits into from
Jan 11, 2019

Conversation

XAMPPRocky
Copy link
Member

Rendered

r? @Mark-Simulacrum
cc @rust-lang/release

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2019
@pietroalbini pietroalbini added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jan 9, 2019
@pietroalbini
Copy link
Member

RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
been changed from `*const` to `*mut` as the previous implementation
was unsound.

[55148]: https://github.com/rust-lang/rust/pull/55148/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some kind of formatting issue; for me, all entries below this point show up as part of one huge block of text.

Copy link
Member Author

@XAMPPRocky XAMPPRocky Jan 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was caused by the fact that GitHub's markdown editor doesn't like having inner brackets in a link even when wrapped in graves, and breaks all links after it. In this case the notation for slices breaks it.
[`[T]::as_ptr`]

Co-Authored-By: Aaronepower <Aaronepower@users.noreply.github.com>
@XAMPPRocky
Copy link
Member Author

@bors r+ high

@bors
Copy link
Contributor

bors commented Jan 10, 2019

📌 Commit 359e6bf has been approved by Aaronepower

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2019
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting nits.

RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
@XAMPPRocky
Copy link
Member Author

@bors r+ p=1000

@bors
Copy link
Contributor

bors commented Jan 10, 2019

📌 Commit 890a8a4 has been approved by Aaronepower

@bors
Copy link
Contributor

bors commented Jan 11, 2019

⌛ Testing commit 890a8a4 with merge 729d3f0...

@bors
Copy link
Contributor

bors commented Jan 11, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Aaronepower
Pushing 729d3f0 to master...

@bors bors merged commit 890a8a4 into rust-lang:master Jan 11, 2019
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 11, 2019
bors added a commit that referenced this pull request Jan 11, 2019
[beta] Rollup backports

Cherry-picked:

* #57355: use the correct supertrait substitution in `object_ty_for_trait`
* #57471: Updated RELEASES.md for 1.32.0

Rolled up:

* #57483: [beta] Uniform path backports
  * c658d73: resolve: Avoid "self-confirming" resolutions in import validation
  * #57160: resolve: Fix an ICE in import validation
  * #56759: Stabilize `uniform_paths`

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants