Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vim: improvements on comments #5760

Closed
wants to merge 3 commits into from
Closed

Vim: improvements on comments #5760

wants to merge 3 commits into from

Conversation

klutzy
Copy link
Contributor

@klutzy klutzy commented Apr 6, 2013

  1. disable nested comment which is not supported now
  2. add syntax highlight for rustCommentDoc e.g. /** doc */ or /// doc.

Since comment nesting does not work from 0.4.
@steveklabnik
Copy link
Member

add syntax highlight for rustCommentDoc e.g. /** doc */ or /// doc.

🤘

@thestinger
Copy link
Contributor

@klutzy: this seems to break on comments that consist of just a line with //

I'll definitely accept this if you update it for that case, making the doc comments stand out is great.

Previous commit had a bug that a line which ends with "//" or "/*"
is not correctly highlighted.
@klutzy
Copy link
Contributor Author

klutzy commented Apr 7, 2013

Vim regex always makes me crazy :)

bors added a commit that referenced this pull request Apr 8, 2013
1. disable nested comment which is not supported now
2. add syntax highlight for rustCommentDoc e.g. `/** doc */` or `/// doc`.
@bors bors closed this Apr 8, 2013
bors added a commit that referenced this pull request Apr 10, 2013
Follow-up of #5760:
Add syntax highlight for `/*! doc */` or `//! doc`.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 14, 2020
…hearth

Deprecate regex_macro lint

Closes rust-lang#2586

changelog: Deprecate regex_macro lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants