Get rid of the fake stack frame for reading from constants #57606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
(I'm on a conference, and will start catching up with my emails on Jan 22nd.) |
|
@bors try |
|
⌛ Trying commit b805232 with merge a5a18a4e3822d2c19cb9cc6752bcc8930f8162e8... |
|
@rust-timer build a5a18a4e3822d2c19cb9cc6752bcc8930f8162e8 |
|
Success: Queued a5a18a4e3822d2c19cb9cc6752bcc8930f8162e8 with parent 33e6df4, comparison URL. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
kennytm
added
S-waiting-on-review
|
Finished benchmarking try commit a5a18a4e3822d2c19cb9cc6752bcc8930f8162e8 |
RalfJung
reviewed
Jan 22, 2019
RalfJung
reviewed
Jan 22, 2019
|
☔ The latest upstream changes (presumably #57830) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Thanks! @bors r+ |
|
📌 Commit d4ee556 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 24, 2019
Get rid of the fake stack frame for reading from constants r? @RalfJung fixes the ice in rust-lang#53708 but still keeps around the wrong "non-exhaustive match" error cc @varkor
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 24, 2019
Get rid of the fake stack frame for reading from constants r? @RalfJung fixes the ice in rust-lang#53708 but still keeps around the wrong "non-exhaustive match" error cc @varkor
bors
added a commit
that referenced
this pull request
Jan 24, 2019
Rollup of 9 pull requests Successful merges: - #57380 (Fix Instant/Duration math precision & associativity on Windows) - #57606 (Get rid of the fake stack frame for reading from constants) - #57803 (Several changes to libunwind for SGX target) - #57846 (rustdoc: fix ICE from loading proc-macro stubs) - #57860 (Add os::fortanix_sgx::ffi module) - #57861 (Don't export table by default in wasm) - #57863 (Add suggestion for incorrect field syntax.) - #57867 (Fix std::future::from_generator documentation) - #57873 (Stabilize no_panic_pow) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @RalfJung
fixes the ice in #53708 but still keeps around the wrong "non-exhaustive match" error
cc @varkor