Two HIR tweaks #57658
Merged
Two HIR tweaks #57658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's simpler and makes some benchmark run up to 1% faster. It also makes `hir::ExprKind` more like `ast::ExprKind` (which underwent the equivalent change in rust-lang#55777).
It's identical to `ast::Label`.
|
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thanks, @nnethercote! @bors r+ rollup |
|
📌 Commit dc45528 has been approved by |
bors
added
S-waiting-on-bors
|
Should these wait until 1.32 releases/branches, to avoid causing problems for tools like clippy? |
|
Yeah, better safe than sorry. @bors r- |
bors
added
S-waiting-on-author
|
1.32 has been released. @bors r=michaelwoerister |
|
📌 Commit dc45528 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 18, 2019
…woerister Two HIR tweaks Two HIR tweaks that make things slightly simpler and faster.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 18, 2019
…woerister Two HIR tweaks Two HIR tweaks that make things slightly simpler and faster.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 18, 2019
…woerister Two HIR tweaks Two HIR tweaks that make things slightly simpler and faster.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 18, 2019
…woerister Two HIR tweaks Two HIR tweaks that make things slightly simpler and faster.
bors
added a commit
that referenced
this pull request
Jan 18, 2019
Rollup of 11 pull requests Successful merges: - #57107 (Add a regression test for mutating a non-mut #[thread_local]) - #57132 (Document that `-C opt-level=0` implies `-C debug-assertions`.) - #57212 (docs(rustc): Link to the book's source in rustc) - #57302 (Fix unused_assignments false positive) - #57350 (Better error note on unimplemented Index trait for string) - #57635 (use structured macro and path resolve suggestions) - #57650 (librustc_metadata: Pass a default value when unwrapping a span) - #57657 (Add regression test to close #53787) - #57658 (Two HIR tweaks) - #57720 (Fix suggestions given mulitple bad lifetimes) - #57725 (Use structured suggestion to surround struct literal with parenthesis) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two HIR tweaks that make things slightly simpler and faster.