Fix memory leak in P::filter_map #57667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors try |
|
⌛ Trying commit 763392c with merge 4fffff535f16a7336e47d6930fe9cc50a2073b6e... |
|
☀️ Test successful - checks-travis |
|
@rust-timer build 4fffff535f16a7336e47d6930fe9cc50a2073b6e |
|
Success: Queued 4fffff535f16a7336e47d6930fe9cc50a2073b6e with parent e2f221c, comparison URL. |
|
Finished benchmarking try commit 4fffff535f16a7336e47d6930fe9cc50a2073b6e |
|
r? @nnethercote Edit: couldn't assign as he/she isn't a rust-lang member, but anyway requesting a review based on git blame. |
|
Nice catch. How did you find it? @bors r+ |
|
📌 Commit 763392c has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 21, 2019
Fix memory leak in P::filter_map Probably this function isn't widely used, but anyway this wasn't working as intended. r? @eddyb Do not rollup if you want to see if max-rss change in perf.
|
Nothing special, I was just learning the AST internals and during the review of the source this came up. |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 22, 2019
Fix memory leak in P::filter_map Probably this function isn't widely used, but anyway this wasn't working as intended. r? @eddyb Do not rollup if you want to see if max-rss change in perf.
bors
added a commit
that referenced
this pull request
Jan 22, 2019
Rollup of 9 pull requests Successful merges: - #57537 (Small perf improvement for fmt) - #57552 (Default images) - #57604 (Make `str` indexing generic on `SliceIndex`.) - #57667 (Fix memory leak in P::filter_map) - #57677 (const_eval: Predetermine the layout of all locals when pushing a stack frame) - #57791 (Add regression test for #54582) - #57798 (Corrected spelling inconsistency) - #57809 (Add powerpc64-unknown-freebsd) - #57813 (fix validation range printing when encountering undef) Failed merges: r? @ghost
eddyb
reviewed
Jan 30, 2019
| @@ -101,6 +101,7 @@ impl<T: 'static> P<T> { | |||
| // Recreate self from the raw pointer. | |||
| Some(P { ptr: Box::from_raw(p) }) | |||
| } else { | |||
| drop(Box::from_raw(p)); | |||
There was a problem hiding this comment.
This is wrong, because of the ptr::read(p) call above - you need to deallocate without dropping the T value inside the Box.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2019
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 11, 2019
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 11, 2019
pietroalbini
pushed a commit
to pietroalbini/rust
that referenced
this pull request
Apr 2, 2019
pietroalbini
pushed a commit
to pietroalbini/rust
that referenced
this pull request
Apr 6, 2019
bors
added a commit
that referenced
this pull request
Apr 7, 2019
[beta] Rollup backports Cherry-picked: * #58021: Fix fallout from #57667 * #59599: Updated RELEASES.md for 1.34.0 * #59587: Remove #[doc(hidden)] from Error::type_id * #58994: Hide deprecation warnings inside derive expansions * #58015: Expand docs for `TryFrom` and `TryInto`. * #59770: ci: pin android emulator to 28.0.23 * #59704: ci: Update FreeBSD tarball downloads * #59257: Update CI configuration for building Redox libraries * #59724: Function arguments should never get promoted r? @ghost
bors
added a commit
that referenced
this pull request
Apr 8, 2019
[beta] Rollup backports Cherry-picked: * #58021: Fix fallout from #57667 * #59599: Updated RELEASES.md for 1.34.0 * #59587: Remove #[doc(hidden)] from Error::type_id * #58994: Hide deprecation warnings inside derive expansions * #58015: Expand docs for `TryFrom` and `TryInto`. * #59770: ci: pin android emulator to 28.0.23 * #59704: ci: Update FreeBSD tarball downloads * #59257: Update CI configuration for building Redox libraries * #59724: Function arguments should never get promoted * #59499: Fix broken download link in the armhf-gnu image * #58330: Add rustdoc JS non-std tests * #58848: Prevent cache issues on version updates r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably this function isn't widely used, but anyway this wasn't working as intended.
r? @eddyb
Do not rollup if you want to see if max-rss change in perf.