Avoid erase_regions_ty queries if there are no regions to erase #57674
Conversation
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
local rustc-perf run, I hope I got everything correctly setup and the numbers are correct |
|
@bors try |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
⌛ Trying commit 960498296aaf009ad950bcd5ffc2a9dfe947539b with merge 4f087d9f32e4d9779b3a947acb2d361457b65957... |
|
Whoops, I was a bit premature there. |
|
Haha, that's what you get when you manually copy a change into a different working space |
|
@bors try |
Avoid erase_regions_ty queries if there are no regions to erase It's overall faster to perform this extra check than to perform the query, even if the result is already in the query cache.
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
☀️ Test successful - checks-travis |
|
Missed the part about anonymizing late bound regions, thought I had that covered compared to an earlier attempt. Building/benchmarking a new version now, will check back tomorrow. |
It's overall faster to perform this extra check than to perform the query, even if the result is already in the query cache.
|
@bors try |
|
⌛ Trying commit da06898 with merge 1c626d926dbde0110dff961226373f8f28946470... |
|
This passes tests for me, except for a reproducible-build test, but that one also fails on master here, so... |
|
☀️ Test successful - checks-travis |
|
@varkor could you start a timing run for this PR? |
|
@rust-timer build 1c626d926dbde0110dff961226373f8f28946470 |
|
Success: Queued 1c626d926dbde0110dff961226373f8f28946470 with parent 722b4d6, comparison URL. |
|
Seems that prlo got stuck |
|
Ah -- the parent commit for this try build was the accidental beta merge to master -- @bors try I've deleted the job from perf and we'll want to re-start that once the try build finishes |
|
Do I need to push a rebased version of this to make that work? |
|
Uh, I think hopefully no -- maybe @bors try- retry try will make bors behave? |
|
@bors retry |
bors
added
S-waiting-on-bors
|
@bors try |
|
⌛ Trying commit da06898 with merge 9bb2812b2691b02ac6212836cf29f93d9d47b78f... |
|
☀️ Test successful - checks-travis |
|
@Mark-Simulacrum could you queue this for prlo again? Thanks! |
|
@rust-timer build 9bb2812b2691b02ac6212836cf29f93d9d47b78f |
|
Success: Queued 9bb2812b2691b02ac6212836cf29f93d9d47b78f with parent 52fec81, comparison URL. |
|
Finished benchmarking try commit 9bb2812b2691b02ac6212836cf29f93d9d47b78f |
dotdash
added
S-waiting-on-review
|
@varkor just wanted to check if you think you could review this, or whether I should ask someone else. Thanks. |
|
📌 Commit da06898 has been approved by |
bors
added
S-waiting-on-bors
Avoid erase_regions_ty queries if there are no regions to erase It's overall faster to perform this extra check than to perform the query, even if the result is already in the query cache.
Rollup of 7 pull requests Successful merges: - #57045 (Kill remaining uses of mem::uninitialized in libcore, liballoc) - #57674 (Avoid erase_regions_ty queries if there are no regions to erase) - #57833 (Print a slightly clearer message when failing to launch a thread) - #57859 (Fix invalid background color) - #57904 (add typo suggestion to unknown attribute error) - #57915 (Pretty print `$crate` as `crate` or `crate_name` in more cases) - #57950 (Extend E0106, E0261) Failed merges: r? @ghost
It's overall faster to perform this extra check than to perform the
query, even if the result is already in the query cache.