Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SGX target: clean up dist builder, update libunwind #57914

Merged
merged 3 commits into from
Jan 31, 2019
Merged

SGX target: clean up dist builder, update libunwind #57914

merged 3 commits into from
Jan 31, 2019

Conversation

jethrogb
Copy link
Contributor

@jethrogb jethrogb commented Jan 26, 2019 •
edited
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2019
jethrogb
jethrogb commented Jan 26, 2019
View reviewed changes
src/ci/init_repo.sh
local module=$1
local cached="download-${module//\//-}.tar.gz"
retry sh -c "rm -f $cached && \
curl -sSL -o $cached $2"
curl -f -sSL -o $cached $2"
Copy link
Contributor Author

@jethrogb jethrogb Jan 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without -f, this only fails on network errors, not on e.g. 404 Not Found.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 28, 2019

📌 Commit 9ce3cfa has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2019
@bors
Copy link
Contributor

bors commented Jan 29, 2019

⌛ Testing commit 9ce3cfa with merge 75c2e7b976931bc78839362745a94dc55a367b90...

@bors
Copy link
Contributor

bors commented Jan 29, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 29, 2019
@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:02:24]  ---> 51da13068bbc
[00:02:24] Step 5/35 : RUN apt-key adv --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
[00:02:24]  ---> Running in fb39503ebd30
[00:02:25] Warning: apt-key output should not be parsed (stdout is not a terminal)
[00:02:25] Executing: /tmp/apt-key-gpghome.VIFxyrk2HM/gpg.1.sh --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
[00:02:27] gpg: Total number processed: 1
[00:02:27] gpg:               imported: 1
[00:02:28] Removing intermediate container fb39503ebd30
[00:02:28]  ---> 2bfdd7d1926b
---
travis_time:end:0f7d3640:start=1548768709540306357,finish=1548768709547386648,duration=7080291
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1b26a900
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:03a538af
travis_time:start:03a538af
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0018e37c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jethrogb
Copy link
Contributor Author 

[00:36:36] Step 17/35 : RUN /tmp/build-x86_64-fortanix-unknown-sgx-toolchain.sh "75628849f538a62712353ac6e4c9e789da90923e"
[00:36:36]  ---> Running in 6087eb91a77b
[00:36:36] + hide_output install_prereq
[00:36:40] + hide_output build_unwind
[00:37:11] The command '/bin/sh -c /tmp/build-x86_64-fortanix-unknown-sgx-toolchain.sh "75628849f538a62712353ac6e4c9e789da90923e"' returned a non-zero code: 2

@VardhanThigle can you please look into this and also make it so Travis prints useful logs if the build fails?

@jethrogb jethrogb mentioned this pull request Jan 30, 2019
Closed
@jethrogb
Copy link
Contributor Author

Should be fixed now

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 31, 2019

📌 Commit b025557 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2019
@bors
Copy link
Contributor

bors commented Jan 31, 2019

⌛ Testing commit b025557 with merge 63505b8...

bors added a commit that referenced this pull request Jan 31, 2019
@bors
Auto merge of #57914 - jethrogb:jb/sgx-unwind-version, r=alexcrichton
63505b8 
SGX target: clean up dist builder, update libunwind

This incorporates fortanix/llvm-project#4

Fixes fortanix/rust-sgx#65

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Jan 31, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 63505b8 to master...

@bors bors merged commit b025557 into rust-lang:master Jan 31, 2019
@workingjubilee workingjubilee added the O-SGX Target: SGX label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
O-SGX Target: SGX S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue linking libunwind in release mode when using LTO
5 participants
@jethrogb @alexcrichton @bors @rust-highfive @workingjubilee