Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move privacy checking later in the pipeline and make some passes run in parallel #58010

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Move privacy checking later in the pipeline and make some passes run in parallel #58010

merged 1 commit into from
Feb 7, 2019

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jan 30, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2019
@michaelwoerister
Copy link
Member

Looks good! Can you explain why you moved privacy checking?

@Zoxc
Copy link
Contributor Author

Zoxc commented Feb 6, 2019

I moved it so it could run in parallel with other more expensive non-incremental passes (helps with incremental compilation). I want to get stability checking down there too, but it was giving me strange errors if done after type collecting, so I skipped that for now.

@michaelwoerister
Copy link
Member

OK, makes sense. Thanks, @Zoxc!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 6, 2019

📌 Commit 38bcd4b has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2019
@bors
Copy link
Contributor

bors commented Feb 7, 2019

⌛ Testing commit 38bcd4b with merge ad43389...

bors added a commit that referenced this pull request Feb 7, 2019
@bors
Auto merge of #58010 - Zoxc:parallel-passes, r=michaelwoerister
ad43389 
Move privacy checking later in the pipeline and make some passes run in parallel

r? @michaelwoerister
@bors bors mentioned this pull request Feb 7, 2019
Merged
@bors
Copy link
Contributor

bors commented Feb 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: michaelwoerister
Pushing ad43389 to master...

@bors bors merged commit 38bcd4b into rust-lang:master Feb 7, 2019
This was referenced Feb 7, 2019
Closed
Merged
@pietroalbini pietroalbini added the merged-by-bors This PR was explicitly merged by bors. label Feb 7, 2019
@Zoxc Zoxc deleted the parallel-passes branch February 7, 2019 17:18
@Manishearth Manishearth mentioned this pull request Mar 9, 2019
Closed
@aturon aturon mentioned this pull request Aug 16, 2019
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zoxc @michaelwoerister @bors @pietroalbini @rust-highfive