Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 15 pull requests #58282

Closed
wants to merge 31 commits into from
Closed

Rollup of 15 pull requests #58282

wants to merge 31 commits into from

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Feb 8, 2019

Successful merges:

Failed merges:

r? @ghost

king6cong and others added 30 commits January 9, 2019 19:07
Update reference of rlibc crate to compiler-builtins crate

None
Transition compiletest to Rust 2018

This transitions `src/tools/compiletest` to Rust 2018.

cc rust-lang#58099
Transition rustdoc to 2018 edition

Transitions rustdoc to Rust 2018; cc rust-lang#58099
…r=Centril

Transition build_helper to 2018 edition

Transitions build_helper to Rust 2018; cc rust-lang#58099
r? @Centril
Partially HirId-ify rustc

Another step towards rust-lang#57578.
Partially Hiridify typeck

Another step towards rust-lang#57578.
Add Cargo.lock automatically adding message

If I execute `cargo +nightly fix`, this change always occurs; cc rust-lang#58099
r? @Centril
rustdoc: display sugared return types for async functions

Fixes rust-lang#58027.
…lexcrichton

Add embedded book to test such that checktools works

r? @alexcrichton

FWIW this doesn't attempt to make sure we don't break check tools again -- we intentionally make the bash script not exit when x.py fails so we'd need some special case handling so for now I'm just fixing the bug itself, not its cause.
…Centril

librustc_allocator => 2018

Transitions `librustc_allocator` to Rust 2018; cc rust-lang#58099

r? @Centril
…, r=Centril

librustc_save_analysis => 2018

Transitions `librustc_save_analysis` to Rust 2018; cc rust-lang#58099

r? @Centril
Add #[must_use] message to Fn* traits

This PR adds `#[must_use]` message to `Fn*` traits.

Related: rust-lang#57549

r? @estebank
…Simulacrum

libcore, liballoc: disable tests in Miri

I am going to run the libcore and liballoc unit test suites in Miri.  Not all tests pass.  This PR disables a whole bunch of tests when running in Miri, to get us to a baseline from which I can investigate failures.

Cc @SimonSapin @alexcrichton
@kennytm
Copy link
Member Author

kennytm commented Feb 8, 2019

@bors r+ p=15

@bors
Copy link
Contributor

bors commented Feb 8, 2019

📌 Commit 4a89289 has been approved by kennytm

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 8, 2019
@bors
Copy link
Contributor

bors commented Feb 8, 2019

⌛ Testing commit 4a89289 with merge 8255e009c0e3d86bf7ace0e9210ccb0af21d15c9...

@bors
Copy link
Contributor

bors commented Feb 8, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 8, 2019
@phansch
Copy link
Member

phansch commented Feb 8, 2019

Looks like a spurious network failure:

Initialized empty Git repository in /c/projects/rust/build/ct/servo/.git/
fatal: Could not parse object '987e376ca7a4245dbc3e0c06e963278ee1ac92d1'.
fatal: unable to access 'https://github.com/servo/servo/': Could not resolve host: github.com

https://ci.appveyor.com/project/rust-lang/rust/builds/22218713/job/eyudermjtanbv5i2#L5793

@kennytm
Copy link
Member Author

kennytm commented Feb 8, 2019

The next few PRs are not quite suitable for rollup, let's try again tomorrow.

@kennytm kennytm closed this Feb 8, 2019
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.