Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 19 pull requests #58348

Closed
wants to merge 46 commits into from
Closed

Conversation

pietroalbini
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

king6cong and others added 30 commits January 9, 2019 19:07
It is easier and it should be also faster, because `to_ne_bytes` just calls `mem::transmute`.
This is not really significant, accept or reject as you wish.  I
just want to make sure I understand how the PR process works and
I'm doing it right before doing a bigger one for rust-lang#33417.
Update reference of rlibc crate to compiler-builtins crate

None
…r=scottmcm

Use `to_ne_bytes` for converting IPv4Addr to octets

It is easier and it should be also faster, because [`to_ne_bytes`](https://doc.rust-lang.org/std/primitive.u32.html#method.to_ne_bytes) just calls `mem::transmute`.
Tiny expansion to docs for `core::convert`.

This is not really significant, accept or reject as you wish.  I just want to make sure I understand how the PR process works and that I'm doing it right before doing a bigger one for rust-lang#33417.
MaybeUninit: some docs, rename into_inner -> into_initialized, return &mut from set
Partially HirId-ify rustc

Another step towards rust-lang#57578.
Partially Hiridify typeck

Another step towards rust-lang#57578.
Add Cargo.lock automatically adding message

If I execute `cargo +nightly fix`, this change always occurs; cc rust-lang#58099
r? @Centril
rustdoc: display sugared return types for async functions

Fixes rust-lang#58027.
Add #[must_use] message to Fn* traits

This PR adds `#[must_use]` message to `Fn*` traits.

Related: rust-lang#57549

r? @estebank
std::sys::unix::stdio: explain why we do into_raw

I was quite puzzled why someone would call `into_raw` and then ignore the result.
…rochenkov

librustc_typeck => 2018

Transitions `librustc_typeck` to Rust 2018; cc rust-lang#58099

TODO: elided_lifetimes_in_paths

r? @Centril
…r=petrochenkov

librustc_codegen_ssa => 2018

Transitions `librustc_codegen_ssa` to Rust 2018; cc rust-lang#58099

r? @petrochenkov
miri: give non-generic functions a stable address

This makes Miri correctly handle format string parameters despite rust-lang#58320.

Matching Miri PR: rust-lang/miri#626

r? @oli-obk
…r=oli-obk

operand-to-place copies should never be overlapping

This seems to just work (verified with the Miri test suite).

r? @oli-obk
When there are multiple filenames, print what got interpreted as filenames

I have written code that crafts command lines for rustc, and when I get "multiple input filenames provided" it can be quite hard to figure out where in this long list of arguments the mistake is hiding.  Probably I passed an argument to a flag that does not expect an argument, but which flag would that be?

This changes the error message to print the first two filenames, to make it easier to debug what is going on.
rpath computation: explain why we pop()

I was quite confused by this code until I got a debug log of what is going on.
@pietroalbini
Copy link
Member Author

@bors r+ p=19

@bors
Copy link
Contributor

bors commented Feb 10, 2019

📌 Commit a5a09e3 has been approved by pietroalbini

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 10, 2019
@bors
Copy link
Contributor

bors commented Feb 10, 2019

⌛ Testing commit a5a09e3 with merge 591c001e1d0d243c80e4b19a72ae4818efe487e1...

@bors
Copy link
Contributor

bors commented Feb 10, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 10, 2019
@rust-highfive
Copy link
Collaborator

The job dist-aarch64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:05218bc0:start=1549808513296330285,finish=1549808513305914392,duration=9584107
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:030b2ce0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:106c1820
travis_time:start:106c1820
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0f3038a8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@pietroalbini
Copy link
Member Author

Caused by #58129.

@pietroalbini pietroalbini deleted the rollup branch February 10, 2019 15:50
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.