rustc: Update LLVM, remove dead wasm code #58408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
I suspect you're going to run into the new toolchain requirements on the dist builders, per: I'm working on that right now for dist-*-linux builders, at least. In the meantime you can set |
|
☔ The latest upstream changes (presumably #58341) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
update-llvm
branch
from
59de990
to
3e2d424
Compare
|
☔ The latest upstream changes (presumably #58406) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
update-llvm
branch
from
3e2d424
to
fcb7900
Compare
|
ping @matthewjasper, do you think you'll have a chance to take a look at this? No worries if not, can just r? someone else! |
|
This isn't an area of the code I know much about. Could you r? someone else please. |
|
We technically support LLVM 6+ (i.e., that's what the distro LLVM builder in CI uses) -- do we want to continue having the "dead" wasm code? |
|
@Mark-Simulacrum we don't support the wasm target on anything other than our in-tree LLVM |
|
@bors r+ Thanks, @alexcrichton! |
|
📌 Commit fcb79008ce14dd8ab729b1e98f0f306b47c0192c has been approved by |
bors
added
S-waiting-on-bors
|
Since it has submodule updates, ill use this an inbtw rollup filler, @bors p=1 |
|
Apparently bors interpreted this wrongly... @bors p=1 rollup- |
|
⌛ Testing commit fcb79008ce14dd8ab729b1e98f0f306b47c0192c with merge a707a104c3fe2fe04958f73922c5f28927ae720d... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
kennytm
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #58728) made this pull request unmergeable. Please resolve the merge conflicts. |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
|
Docker rebuilt for that container, taking 2.5h, causing a timeout @bors: retry |
bors
added
S-waiting-on-bors
|
Why is In #58416 this seemed to be a problem too. There it really did need docker updates, of course, but it seemed to take a few tries before they all finally stuck. |
bors
added a commit
that referenced
this pull request
Mar 1, 2019
rustc: Update LLVM, remove dead wasm code This commit updates the LLVM branch to the rebased version of the upstream release/8.x branch. This includes a wasm patch which means that the `rewrite_imports` pass in rustc is no longer needed (yay!) and we can instead rely on `wasm-import-module`, an attribute we're already emitting, to take care of all the work.
|
☀️ Test successful - checks-travis, status-appveyor |
|
@cuviper it's probably hashing issues like before, although I won't pretend to know what hashing issues it is... In any case I'm surprised this landed! I guess we don't actually have all that many toolchains to update |
|
I've opened up #58852 to handle the NetBSD toolchain, will look into Windows next. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 1, 2019
Originally added in rust-lang#55935 to test build times, this was reverted in rust-lang#56201 due to a belief that it caused the exit code 259 spurious errors. We've since learned, however, that the 259 exit code is likely not related to this image update as we're getting it in a number of locations now. VS2017 looks like it may be required to compile LLVm in the near future, notably discovered by rust-lang#58408 where we attempted to update LLVM.
|
And #58854 is the attempt for Windows |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 2, 2019
…Simulacrum Update toolchain to build NetBSD release This allows us to remove the "allow old toolchains" flag we pass to LLVM, ensuring that we'll be up to date when LLVM needs us to be! This is a follow-up from rust-lang#58408 where NetBSD was explicitly whitelisted to allow older toolchains.
This was referenced Mar 2, 2019
Closed
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 11, 2019
…-Simulacrum appveyor: Use VS2017 for all our images Originally added in rust-lang#55935 to test build times, this was reverted in rust-lang#56201 due to a belief that it caused the exit code 259 spurious errors. We've since learned, however, that the 259 exit code is likely not related to this image update as we're getting it in a number of locations now. VS2017 looks like it may be required to compile LLVm in the near future, notably discovered by rust-lang#58408 where we attempted to update LLVM.
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Mar 12, 2019
…-Simulacrum appveyor: Use VS2017 for all our images Originally added in rust-lang#55935 to test build times, this was reverted in rust-lang#56201 due to a belief that it caused the exit code 259 spurious errors. We've since learned, however, that the 259 exit code is likely not related to this image update as we're getting it in a number of locations now. VS2017 looks like it may be required to compile LLVm in the near future, notably discovered by rust-lang#58408 where we attempted to update LLVM.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 15, 2019
…-Simulacrum appveyor: Use VS2017 for all our images Originally added in rust-lang#55935 to test build times, this was reverted in rust-lang#56201 due to a belief that it caused the exit code 259 spurious errors. We've since learned, however, that the 259 exit code is likely not related to this image update as we're getting it in a number of locations now. VS2017 looks like it may be required to compile LLVm in the near future, notably discovered by rust-lang#58408 where we attempted to update LLVM.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 16, 2019
…-Simulacrum appveyor: Use VS2017 for all our images Originally added in rust-lang#55935 to test build times, this was reverted in rust-lang#56201 due to a belief that it caused the exit code 259 spurious errors. We've since learned, however, that the 259 exit code is likely not related to this image update as we're getting it in a number of locations now. VS2017 looks like it may be required to compile LLVm in the near future, notably discovered by rust-lang#58408 where we attempted to update LLVM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the LLVM branch to the rebased version of the
upstream release/8.x branch. This includes a wasm patch which means that
the
rewrite_importspass in rustc is no longer needed (yay!) and wecan instead rely on
wasm-import-module, an attribute we're alreadyemitting, to take care of all the work.