Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGX target: fix panic = abort #58453

Merged
merged 1 commit into from
Feb 23, 2019
Merged

Conversation

jethrogb
Copy link
Contributor

What is the difference between no_mangle and rustc_std_internal_symbol?

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2019
@nikomatsakis
Copy link
Contributor

I don't really understand what's going on here. I'm assigning to someone who might. =)

r? @nagisa

@rust-highfive rust-highfive assigned nagisa and unassigned nikomatsakis Feb 22, 2019
@nagisa
Copy link
Member

nagisa commented Feb 22, 2019

What is the difference between no_mangle and rustc_std_internal_symbol?

rustc_std_internal_symbol has different reachability and visibilty semantics than what is usual. no_mangle does not influence either of those.

@bors r+

@bors
Copy link
Contributor

bors commented Feb 22, 2019

📌 Commit 347a42e has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
SGX target: fix panic = abort

What is the difference between `no_mangle` and `rustc_std_internal_symbol`?
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
SGX target: fix panic = abort

What is the difference between `no_mangle` and `rustc_std_internal_symbol`?
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
SGX target: fix panic = abort

What is the difference between `no_mangle` and `rustc_std_internal_symbol`?
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
SGX target: fix panic = abort

What is the difference between `no_mangle` and `rustc_std_internal_symbol`?
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
SGX target: fix panic = abort

What is the difference between `no_mangle` and `rustc_std_internal_symbol`?
bors added a commit that referenced this pull request Feb 23, 2019
Rollup of 16 pull requests

Successful merges:

 - #58100 (Transition librustdoc to Rust 2018)
 - #58122 (RangeInclusive internal iteration performance improvement.)
 - #58199 (Add better error message for partial move)
 - #58227 (Updated RELEASES.md for 1.33.0)
 - #58353 (Check the Self-type of inherent associated constants)
 - #58453 (SGX target: fix panic = abort)
 - #58476 (Remove `LazyTokenStream`.)
 - #58526 (Special suggestion for illegal unicode curly quote pairs)
 - #58595 (Turn duration consts into associated consts)
 - #58609 (Allow Self::Module to be mutated.)
 - #58628 (Optimise vec![false; N] to zero-alloc)
 - #58643 (Don't generate minification variables if minification disabled)
 - #58648 (Update tests to account for cross-platform testing and miri.)
 - #58654 (Do not underflow after resetting unmatched braces count)
 - #58658 (Add expected/provided byte alignments to validation error message)
 - #58667 (Reduce Miri-related Code Repetition `like (n << amt) >> amt`)

Failed merges:

r? @ghost
@bors bors merged commit 347a42e into rust-lang:master Feb 23, 2019
@workingjubilee workingjubilee added the O-SGX Target: SGX label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-SGX Target: SGX S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants