rewrite the ffi tutorial with snappy as an example #5849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for rewriting this! It's a lot better than the previous version. I commented on an outdated revision. Please give them some consideration. |
The example with OpenSSL is incorrect, because OpenSSL is using a static variable for the return value and isn't thread-safe. The gettimeofday example isn't great because it's not very portable.
bors
added a commit
that referenced
this pull request
Apr 12, 2013
The code samples are xfail'ed because the buildbot won't have `libsnappy.so` and I don't want to add boilerplate to all the snippets (but they're directly from my snappy bindings so I'll just send a pull request whenever they break). It works really well as an example because it's tiny library and lets the caller manage all the buffers. I think everything stated in the `Interoperability with foreign code` section is accurate but it deserves a thorough double-check :).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 3, 2020
No lint in macro for `toplevel_ref_arg` Do not lint when the span is from a macro. Question: shouldn't we extend this for external macros also ? Fixes: rust-lang#5849 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code samples are xfail'ed because the buildbot won't have
libsnappy.soand I don't want to add boilerplate to all the snippets (but they're directly from my snappy bindings so I'll just send a pull request whenever they break). It works really well as an example because it's tiny library and lets the caller manage all the buffers.I think everything stated in the
Interoperability with foreign codesection is accurate but it deserves a thorough double-check :).