Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Const to op simplification #58511

Merged
merged 11 commits into from
Feb 24, 2019
Merged

Const to op simplification #58511

merged 11 commits into from
Feb 24, 2019

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Feb 16, 2019

r? @RalfJung

alternative to #58486

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2019
@RalfJung
Copy link
Member

I love this. :)

r=me with the nit fixed.

However, there are other parts of #58486 that are still viable, right? Like, some of the simplifications in const_eval?

@RalfJung
Copy link
Member

RalfJung commented Feb 16, 2019 •
edited
Loading

Hm, I thought op_to_const could be removed/simplified, but having something like that makes sense. I guess the FIXME there can go away now?

It is a bit sad that we need the may_normalized: bool argument there. I think it would be clearer to rename that to force_indirect (with the opposite meaning of may_normalize), because that's really what this is about (for statics/promoteds, we need them to be ByRef). That could make the code clearer, and we could add some assertions to make sure the OpTy is really indirect.

@RalfJung
Copy link
Member

RalfJung commented Feb 16, 2019 •
edited
Loading

Awesome. I love this PR. :)

@bors r+

@bors
Copy link
Contributor

bors commented Feb 16, 2019

📌 Commit 1fe7eb0 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2019
@bors
Copy link
Contributor

bors commented Feb 16, 2019

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Feb 16, 2019

📌 Commit 1fe7eb0 has been approved by RalfJung

Centril added a commit to Centril/rust that referenced this pull request Feb 20, 2019
@Centril
Rollup merge of rust-lang#58511 - oli-obk:const_to_op, r=RalfJung
a8722c2 
Const to op simplification

r? @RalfJung

alternative to rust-lang#58486
@Centril Centril mentioned this pull request Feb 20, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
@Centril
Rollup merge of rust-lang#58511 - oli-obk:const_to_op, r=RalfJung
89c4253 
Const to op simplification

r? @RalfJung

alternative to rust-lang#58486
@Centril Centril mentioned this pull request Feb 23, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Feb 24, 2019
@Centril
Rollup merge of rust-lang#58511 - oli-obk:const_to_op, r=RalfJung
284787b 
Const to op simplification

r? @RalfJung

alternative to rust-lang#58486
@Centril Centril mentioned this pull request Feb 24, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Feb 24, 2019
@Centril
Rollup merge of rust-lang#58511 - oli-obk:const_to_op, r=RalfJung
1082a29 
Const to op simplification

r? @RalfJung

alternative to rust-lang#58486
@Centril Centril mentioned this pull request Feb 24, 2019
Merged
bors added a commit that referenced this pull request Feb 24, 2019
@bors
Auto merge of #58691 - Centril:rollup, r=Centril
e17c48e 
Rollup of 6 pull requests

Successful merges:

 - #57364 (Improve parsing diagnostic for negative supertrait bounds)
 - #58183 (Clarify guarantees for `Box` allocation)
 - #58442 (Simplify the unix `Weak` functionality)
 - #58454 (Refactor Windows stdio and remove stdin double buffering )
 - #58511 (Const to op simplification)
 - #58642 (rustdoc: support methods on primitives in intra-doc links)

Failed merges:

r? @ghost
@bors bors merged commit 1fe7eb0 into rust-lang:master Feb 24, 2019
@RalfJung RalfJung mentioned this pull request Feb 24, 2019
Closed
@matthewjasper matthewjasper mentioned this pull request Feb 25, 2019
Closed
@oli-obk oli-obk deleted the const_to_op branch March 16, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@RalfJung RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oli-obk @RalfJung @bors @rust-highfive