Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaybeUninit: add read_initialized, add examples #58660

Merged
merged 15 commits into from
Mar 9, 2019
Merged

MaybeUninit: add read_initialized, add examples #58660

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
13ffbee
Add MaybeUninit::read_uninitialized
RalfJung Feb 22, 2019
dc570fb
also add examples to MaybeUninit::into_initialized
RalfJung Feb 22, 2019
10f511d
misc tweaks
RalfJung Feb 22, 2019
48aa59e
examples for as[_mut]_ptr
RalfJung Feb 22, 2019
084ee7a
examples for MaybeUninit::zeroed
RalfJung Feb 22, 2019
d10366f
avoid unnecessary use of MaybeUninit::get_ref, and expand comment on …
RalfJung Feb 22, 2019
aa4a9b0
make MaybeUninit Copy
RalfJung Feb 22, 2019
53c0275
Apply suggestions from code review
Centril Feb 23, 2019
ac2284b
expand type name
RalfJung Feb 23, 2019
8ce9b86
fix link
RalfJung Feb 23, 2019
a5e2d0c
remark that the rules are unfinished
RalfJung Feb 24, 2019
be8d728
show how to set with ptr::write
RalfJung Feb 24, 2019
6d32e5a
prefer into_initialized over read_initialited
RalfJung Feb 24, 2019
90bb07e
Apply suggestions from code review
Centril Mar 6, 2019
cefe9b0
Apply suggestions from code review
RalfJung Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/libcore/fmt/float.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ fn float_to_decimal_common_exact<T>(fmt: &mut Formatter, num: &T,
// FIXME(#53491): Technically, this is calling `get_mut` on an uninitialized
// `MaybeUninit` (here and elsewhere in this file). Revisit this once
// we decided whether that is valid or not.
// Using `freeze` is *not enough*; `flt2dec::Part` is an enum!
let formatted = flt2dec::to_exact_fixed_str(flt2dec::strategy::grisu::format_exact,
*num, sign, precision,
false, buf.get_mut(), parts.get_mut());
Expand All @@ -33,6 +34,7 @@ fn float_to_decimal_common_shortest<T>(fmt: &mut Formatter, num: &T,
// enough for f32 and f64
let mut buf = MaybeUninit::<[u8; flt2dec::MAX_SIG_DIGITS]>::uninitialized();
let mut parts = MaybeUninit::<[flt2dec::Part; 4]>::uninitialized();
// FIXME(#53491)
let formatted = flt2dec::to_shortest_str(flt2dec::strategy::grisu::format_shortest, *num,
sign, precision, false, buf.get_mut(),
parts.get_mut());
Expand Down Expand Up @@ -71,6 +73,7 @@ fn float_to_exponential_common_exact<T>(fmt: &mut Formatter, num: &T,
unsafe {
let mut buf = MaybeUninit::<[u8; 1024]>::uninitialized(); // enough for f32 and f64
let mut parts = MaybeUninit::<[flt2dec::Part; 6]>::uninitialized();
// FIXME(#53491)
let formatted = flt2dec::to_exact_exp_str(flt2dec::strategy::grisu::format_exact,
*num, sign, precision,
upper, buf.get_mut(), parts.get_mut());
Expand All @@ -90,6 +93,7 @@ fn float_to_exponential_common_shortest<T>(fmt: &mut Formatter,
// enough for f32 and f64
let mut buf = MaybeUninit::<[u8; flt2dec::MAX_SIG_DIGITS]>::uninitialized();
let mut parts = MaybeUninit::<[flt2dec::Part; 6]>::uninitialized();
// FIXME(#53491)
let formatted = flt2dec::to_shortest_exp_str(flt2dec::strategy::grisu::format_shortest,
*num, sign, (0, 0), upper,
buf.get_mut(), parts.get_mut());
Expand Down
Loading