Rollup of 15 pull requests #58770
Closed
Rollup of 15 pull requests #58770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report all unused attributes on a given doc comment instead of just the first one, and extend the span of sugared doc comments to encompass the whole comment.
Report the diagnostic on macro expansions, and add a label indicating why the comment is unused.
Fix style issues and update diagnostic messages Update src/librustc_passes/diagnostics.rs Co-Authored-By: doctorn <me@nathancorbyn.com> Deny nested `async fn` in Rust 2015 edition Deny nested `async fn` in Rust 2015 edition Deny nested `async fn` in Rust 2015 edition
* A number of `Stdio` related doc examples include running the "rev" command to illustrate piping commands. The majority of these tests are marked as `no_run` except for two tests which were not * Not running these tests is unlikely to cause any negative impact, and doing so also allows the test suite to pass in environments where the "rev" command is unavailable
I wondered what the `<<!` operator is although the exclamation mark was only the end of the sentence.
This is required at the very least in order to evaluate associated constants for arrays (see rust-lang#58212).
Signed-off-by: Adonis <adonis.settouf@gmail.com> Update src/libsyntax/ext/tt/quoted.rs Co-Authored-By: asettouf <adonis.settouf@gmail.com> Update src/libsyntax/ext/tt/quoted.rs Co-Authored-By: asettouf <adonis.settouf@gmail.com> Update src/libsyntax/ext/tt/quoted.rs Co-Authored-By: asettouf <adonis.settouf@gmail.com> Update src/libsyntax/ext/tt/quoted.rs Co-Authored-By: asettouf <adonis.settouf@gmail.com> Update src/libsyntax/ext/tt/quoted.rs Co-Authored-By: asettouf <adonis.settouf@gmail.com> Update src/libsyntax/ext/tt/quoted.rs Co-Authored-By: asettouf <adonis.settouf@gmail.com> Update src/test/ui/macros/macro-at-most-once-rep-2015-ques-rep.stderr Co-Authored-By: asettouf <adonis.settouf@gmail.com> Update src/test/ui/macros/macro-at-most-once-rep-2015-ques-rep.stderr Co-Authored-By: asettouf <adonis.settouf@gmail.com> Stabilize split_ascii_whitespace Tracking issue FCP to merge: rust-lang#48656 (comment) fix stabilization order of uniform_paths. hir: add HirId to main Hir nodes Fix `std::os::fortanix_sgx::usercalls::raw::UsercallNrs` Fixes fortanix/rust-sgx#88 Update src/libsyntax/ext/tt/quoted.rs Co-Authored-By: asettouf <adonis.settouf@gmail.com> Revert "Merge remote-tracking branch 'upstream/master'" This reverts commit 751f05bd155e2c55d4177fe8211df634faf3a644, reversing changes made to 545a3e62b0cb473108869a61b271bc589afb49da.
…ebank overhaul unused doc comments lint This PR contains a number of improvements to the `unused_doc_comments` lint. - Extends the span to cover the entire comment when using sugared doc comments. - Triggers the lint for all unused doc comments on a node, instead of just the first one. - Triggers the lint on macro expansions, and provides a help note explaining that doc comments must be expanded by the macro. - Adds a label pointing at the node that cannot be documented. Furthermore, this PR fixes any instances in rustc where a macro expansion was erroneously documented.
Fix for issue rust-lang#58050 Hi, a quick PR to mention in the compiler error message that `?` is a macro operator, as according to issue rust-lang#58050 It passed `python x.py test src/tools/tidy` locally, as well as the recommendation to run `/x.py test src/test/ui --stage 1 --bless`. Let me know if anything else is needed.
…isdreavus rustdoc: move collapse and unindent docs passes earlier Moves these passes as early as possible so later passes will see the same markdown that is passed to the test collector. Fixes rust-lang#58473, and a similar issue with the private-doc-tests lint. r? @QuietMisdreavus
…rochenkov Make `visit_clobber` panic-safe. Local measurements indicate the performance effect is negligible. r? @petrochenkov
…n, r=varkor
Deny `async fn` in 2015 edition
This commit prevents code using `async fn` from being compiled in Rust 2015 edition.
Compiling code of the form:
```rust
async fn foo() {}
```
Will now result in the error:
```
error[E0670]: `async fn` is not permitted in the 2015 edition
--> async.rs:1:1
|
1 | async fn foo() {}
| ^^^^^
error: aborting due to error
For more information about an error, try `rustc --explain E0670`.
```
This resolves rust-lang#58652 and also resolves rust-lang#53714.
r? @varkor
…crichton Fix an indexing error when using `x.py help` Fixes rust-lang#58640.
Fix copy-pasted typo for read_string return value
…richton Update dlmalloc to 0.1.3 r? @alexcrichton
std: docs: Disable running several Stdio doctests * A number of `Stdio` related doc examples include running the "rev" command to illustrate piping commands. The majority of these tests are marked as `no_run` except for two tests which were not * Not running these tests is unlikely to cause any negative impact, and doing so also allows the test suite to pass in environments where the "rev" command is unavailable
update scoped_tls to 1.0 scoped_tls has been updated to version 1.0 This PR will hopefully merge flawlessly :) This fixes, among others, alexcrichton/scoped-tls#9 Note, that the nightly feature has been removed in alexcrichton/scoped-tls@64bd7b8
Reduce Repetitions of (n << amt) >> amt Fixes part of [rust-lang#49937](rust-lang#49937).
…, r=alexcrichton Update string_cache_codegen to 0.4.2 This removes two dependencies of the old version (string_cache is already the latest version).
Clarify `rotate_{left,right}` docs
I wondered what the `<<!` operator is although the exclamation mark was
only the end of the sentence.
Normalize the type Self resolves to in an impl This is required at the very least in order to evaluate associated constants for arrays. Fixes rust-lang#57796 Fixes rust-lang#58212. r? @oli-obk cc @hellow554
…wind, r=Centril Add tracking issue for the unwind attribute cc rust-lang#58760
|
@bors r+ p=15 |
|
📌 Commit 63b9207 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 63b9207 with merge aa7922039340ca8b5fad8a33f20c011db11cdaea... |
|
💔 Test failed - checks-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
?is not a macro repetition operator" errors #58050)visit_clobberpanic-safe. #58630 (Makevisit_clobberpanic-safe.)async fnin 2015 edition #58678 (Denyasync fnin 2015 edition)x.py help#58680 (Fix an indexing error when usingx.py help)rotate_{left,right}docs #58755 (Clarifyrotate_{left,right}docs)Failed merges:
r? @ghost