Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler_builtins to 0.1.7 to get windows/arm fix #58789

Closed

Conversation

jordanrh1
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2019
Cargo.lock Outdated Show resolved Hide resolved
@sanxiyn
Copy link
Member

sanxiyn commented Mar 2, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Mar 2, 2019

📌 Commit 676b4ef8370862551f4feb1837a1acfc0ee010e8 has been approved by sanxiyn

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2019
@bors
Copy link
Contributor

bors commented Mar 4, 2019

☔ The latest upstream changes (presumably #58807) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2019
@petrochenkov
Copy link
Contributor

@jordanrh1
This needs a rebase.

@petrochenkov petrochenkov assigned sanxiyn and unassigned nikomatsakis Mar 4, 2019
@jordanrh1 jordanrh1 force-pushed the update-compiler-builtins branch from 676b4ef to 7e8758b Compare March 5, 2019 21:57
@jordanrh1
Copy link
Contributor Author

Rebased.

@sanxiyn
Copy link
Member

sanxiyn commented Mar 6, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Mar 6, 2019

📌 Commit 7e8758b has been approved by sanxiyn

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
… r=sanxiyn

Update compiler_builtins to 0.1.7 to get windows/arm fix
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
… r=sanxiyn

Update compiler_builtins to 0.1.7 to get windows/arm fix
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
… r=sanxiyn

Update compiler_builtins to 0.1.7 to get windows/arm fix
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
… r=sanxiyn

Update compiler_builtins to 0.1.7 to get windows/arm fix
Centril added a commit to Centril/rust that referenced this pull request Mar 11, 2019
… r=sanxiyn

Update compiler_builtins to 0.1.7 to get windows/arm fix
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Mar 12, 2019
… r=sanxiyn

Update compiler_builtins to 0.1.7 to get windows/arm fix
Centril added a commit to Centril/rust that referenced this pull request Mar 13, 2019
… r=sanxiyn

Update compiler_builtins to 0.1.7 to get windows/arm fix
@bors
Copy link
Contributor

bors commented Mar 15, 2019

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout update-compiler-builtins (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self update-compiler-builtins --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
warning: Cannot merge binary files: Cargo.lock (HEAD vs. heads/homu-tmp)
Auto-merging Cargo.lock
CONFLICT (content): Merge conflict in Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 15, 2019
@mati865
Copy link
Contributor

mati865 commented Mar 22, 2019

This PR requires rebase, instructions are in #58789 (comment)

@bors
Copy link
Contributor

bors commented Mar 22, 2019

☔ The latest upstream changes (presumably #57810) made this pull request unmergeable. Please resolve the merge conflicts.

@Centril
Copy link
Contributor

Centril commented Mar 30, 2019

Ping from triage, @jordanrh1, you have some rebasing to do.

@bors
Copy link
Contributor

bors commented Apr 1, 2019

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout update-compiler-builtins (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self update-compiler-builtins --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
warning: Cannot merge binary files: Cargo.lock (HEAD vs. heads/homu-tmp)
Auto-merging Cargo.lock
CONFLICT (content): Merge conflict in Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

@mati865
Copy link
Contributor

mati865 commented Apr 3, 2019

Superseded by #59643

@sanxiyn
Copy link
Member

sanxiyn commented Apr 5, 2019

#59643, which updated compiler_builtins to 0.1.9, landed. Closing.

@sanxiyn sanxiyn closed this Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants