Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libstd: deny(elided_lifetimes_in_paths) #58828

Merged
merged 5 commits into from
Mar 31, 2019
Merged

libstd: deny(elided_lifetimes_in_paths) #58828

merged 5 commits into from
Mar 31, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 1, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril Centril force-pushed the deny-elided_lifetimes_in_paths-libstd branch from 1ac0060 to 71842fc Compare March 1, 2019 08:59
@oli-obk
Copy link
Contributor

oli-obk commented Mar 1, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Mar 1, 2019

📌 Commit 71842fcd21836a764c62cca4f271a319b7811e94 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@kennytm
Copy link
Member

kennytm commented Mar 1, 2019

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 1, 2019
@Centril Centril force-pushed the deny-elided_lifetimes_in_paths-libstd branch from 71842fc to ff9173e Compare March 1, 2019 11:53
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@Centril Centril force-pushed the deny-elided_lifetimes_in_paths-libstd branch from ff9173e to 2463d75 Compare March 3, 2019 13:36
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril Centril force-pushed the deny-elided_lifetimes_in_paths-libstd branch from 2463d75 to 6b1e200 Compare March 3, 2019 13:49
@Centril Centril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2019
@Centril
Copy link
Contributor Author

Centril commented Mar 3, 2019

@oli-obk Should hopefully be good to go now. :)

@oli-obk
Copy link
Contributor

oli-obk commented Mar 4, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Mar 4, 2019

📌 Commit 6b1e200 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2019
@bors
Copy link
Contributor

bors commented Mar 15, 2019

⌛ Testing commit 6b1e200 with merge 547c074...

bors added a commit that referenced this pull request Mar 15, 2019
@bors
Auto merge of #58828 - Centril:deny-elided_lifetimes_in_paths-libstd,…
547c074 
… r=oli-obk

libstd: deny(elided_lifetimes_in_paths)

r? @oli-obk
@bors
Copy link
Contributor

bors commented Mar 16, 2019

💔 Test failed - checks-travis

@rust-highfive

This comment has been minimized.

Sign in to view
@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 16, 2019
@Centril Centril force-pushed the deny-elided_lifetimes_in_paths-libstd branch from 13a4ac3 to 351a20c Compare March 31, 2019 10:57
@Centril
Copy link
Contributor Author

Centril commented Mar 31, 2019

Fixed those... 😓

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Mar 31, 2019

📌 Commit 351a20c has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 31, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 31, 2019
@Centril
Rollup merge of rust-lang#58828 - Centril:deny-elided_lifetimes_in_pa…
8546d33 
…ths-libstd, r=oli-obk

libstd: deny(elided_lifetimes_in_paths)

r? @oli-obk
@Centril Centril mentioned this pull request Mar 31, 2019
Closed
@bors
Copy link
Contributor

bors commented Mar 31, 2019

⌛ Testing commit 351a20c with merge 1d435932ef9d6fff7db54a229a1af354f717df57...

@Centril
Copy link
Contributor Author

Centril commented Mar 31, 2019

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Mar 31, 2019

📌 Commit 1d9508a has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Mar 31, 2019

⌛ Testing commit 1d9508a with merge c298fe2aec3fab68c45f257c69529784d7772a70...

Centril added a commit to Centril/rust that referenced this pull request Mar 31, 2019
@Centril
Rollup merge of rust-lang#58828 - Centril:deny-elided_lifetimes_in_pa…
c60e455 
…ths-libstd, r=oli-obk

libstd: deny(elided_lifetimes_in_paths)

r? @oli-obk
@Centril Centril mentioned this pull request Mar 31, 2019
Closed
@Centril
Copy link
Contributor Author

Centril commented Mar 31, 2019

@bors retry

@rust-lang rust-lang deleted a comment from rust-highfive Mar 31, 2019
@bors
Copy link
Contributor

bors commented Mar 31, 2019

⌛ Testing commit 1d9508a with merge c05d12333fa83d0377766cc938e5ce36025362d5...

Centril added a commit to Centril/rust that referenced this pull request Mar 31, 2019
@Centril
Rollup merge of rust-lang#58828 - Centril:deny-elided_lifetimes_in_pa…
a02b825 
…ths-libstd, r=oli-obk

libstd: deny(elided_lifetimes_in_paths)

r? @oli-obk
@Centril Centril mentioned this pull request Mar 31, 2019
Merged
@Centril
Copy link
Contributor Author

Centril commented Mar 31, 2019

@bors retry

bors added a commit that referenced this pull request Mar 31, 2019
@bors
Auto merge of #59584 - Centril:rollup, r=Centril
a89c03a 
Rollup of 4 pull requests

Successful merges:

 - #58828 (libstd: deny(elided_lifetimes_in_paths))
 - #59234 (Mention `no merge policy` in the CONTRIBUTING guide)
 - #59572 (Include bounds in generic re-ordering diagnostic)
 - #59574 (Distinguish message for external macros depending on error level)

Failed merges:

r? @ghost
@bors bors merged commit 1d9508a into rust-lang:master Mar 31, 2019
@Centril Centril deleted the deny-elided_lifetimes_in_paths-libstd branch March 31, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Centril @rust-highfive @oli-obk @bors @kennytm